From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39566)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1UmJv1-0002FH-No
	for qemu-devel@nongnu.org; Tue, 11 Jun 2013 04:27:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1UmJuv-0002xI-C0
	for qemu-devel@nongnu.org; Tue, 11 Jun 2013 04:27:07 -0400
Received: from mx1.redhat.com ([209.132.183.28]:25408)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1UmJuu-0002uK-Tr
	for qemu-devel@nongnu.org; Tue, 11 Jun 2013 04:27:01 -0400
Date: Tue, 11 Jun 2013 11:27:09 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20130611082709.GA9666@redhat.com>
References: <1370882347-31129-1-git-send-email-mst@redhat.com>
	<51B6B68E.9040508@redhat.com> <20130611065525.GB31474@redhat.com>
	<51B6D4E5.2070100@redhat.com> <20130611075314.GG31474@redhat.com>
	<51B6D924.6010802@redhat.com> <20130611081813.GI31474@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130611081813.GI31474@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <anthony@codemonkey.ws>, David Woodhouse <dwmw2@infradead.org>, seabios@seabios.org, qemu-devel@nongnu.org, Kevin O'Connor <kevin@koconnor.net>, Jordan Justen <jljusten@gmail.com>, Laszlo Ersek <lersek@redhat.com>

On Tue, Jun 11, 2013 at 11:18:13AM +0300, Michael S. Tsirkin wrote:
> On Tue, Jun 11, 2013 at 10:00:36AM +0200, Gerd Hoffmann wrote:
> >   Hi,
> > 
> > > Yes and not just because of windows guests.
> > > ACPI spec is also very explicit that native hotplug is an optional
> > > feature. Test suites such as WHQL are known to test spec compliance.
> > 
> > /me looks a bit surprised.
> > 
> > This pretty much implies that any shpc bridge needs a second interface
> > to the hotplug functionality which can be driven via ACPI.  Or the
> > firmware somehow handles this using smm (not sure this works for the IRQ
> > though).
> > 
> > Do you know how this is handled by real hardware?
> > 
> > cheers,
> >   Gerd
> 
> SHPC is not very widely deployed on a PC.
> 
> Since most hardware vendors do care about windows support,
> the only way is a separate interface that is driven via ACPI.
> You then need an ACPI specific register to switch to standard SHPC.
> The SHPC spec even tells you as much.

Just to give another example, interface in this patch
scales trivially to multi-root configurations,
if we ever want to support them.

> -- 
> MST