From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47567) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UmKRj-0004wm-B4 for qemu-devel@nongnu.org; Tue, 11 Jun 2013 05:00:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UmKRe-0005Bp-Iq for qemu-devel@nongnu.org; Tue, 11 Jun 2013 05:00:55 -0400 Received: from e36.co.us.ibm.com ([32.97.110.154]:44026) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UmKRe-0005Bh-8U for qemu-devel@nongnu.org; Tue, 11 Jun 2013 05:00:50 -0400 Received: from /spool/local by e36.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 11 Jun 2013 03:00:49 -0600 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id 4D9D219D8041 for ; Tue, 11 Jun 2013 03:00:37 -0600 (MDT) Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r5B90jB2228178 for ; Tue, 11 Jun 2013 03:00:45 -0600 Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1]) by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r5B937f3025868 for ; Tue, 11 Jun 2013 03:03:07 -0600 Date: Tue, 11 Jun 2013 11:00:43 +0200 From: Jens Freimann Message-ID: <20130611090043.GB27811@linux.vnet.ibm.com> References: <1370794247-28267-1-git-send-email-afaerber@suse.de> <1370794247-28267-13-git-send-email-afaerber@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1370794247-28267-13-git-send-email-afaerber@suse.de> Subject: Re: [Qemu-devel] [PATCH qom-cpu v4 12/18] cpu: Change default for CPUClass::get_paging_enabled() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: qiaonuohan@cn.fujitsu.com, qemu-devel@nongnu.org, lcapitulino@redhat.com On Sun, Jun 09, 2013 at 06:10:41PM +0200, Andreas Färber wrote: > qemu_get_guest_memory_mapping() uses cpu_paging_enabled() to determine > whether to use cpu_get_memory_mapping() to return mappings or whether to > fall back to a simple identity map. > > Since by default CPUClass::get_memory_mapping() is not implemented, > change the default to false to use the identity map by default. > > Signed-off-by: Andreas Färber Reviewed-by: Jens Freimann > --- > qom/cpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qom/cpu.c b/qom/cpu.c > index b25fbc9..dba4a11 100644 > --- a/qom/cpu.c > +++ b/qom/cpu.c > @@ -59,7 +59,7 @@ bool cpu_paging_enabled(const CPUState *cpu) > > static bool cpu_common_get_paging_enabled(const CPUState *cpu) > { > - return true; > + return false; > } > > void cpu_get_memory_mapping(CPUState *cpu, MemoryMappingList *list, > -- > 1.8.1.4 > >