From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52518)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UmQ50-0001bw-3f
	for qemu-devel@nongnu.org; Tue, 11 Jun 2013 11:01:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UmQ4x-00022k-7B
	for qemu-devel@nongnu.org; Tue, 11 Jun 2013 11:01:50 -0400
Received: from mx1.redhat.com ([209.132.183.28]:11990)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UmQ4w-00022Y-Vb
	for qemu-devel@nongnu.org; Tue, 11 Jun 2013 11:01:47 -0400
Date: Tue, 11 Jun 2013 11:01:42 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20130611110142.1f8e9638@redhat.com>
In-Reply-To: <1370794247-28267-13-git-send-email-afaerber@suse.de>
References: <1370794247-28267-1-git-send-email-afaerber@suse.de>
	<1370794247-28267-13-git-send-email-afaerber@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH qom-cpu v4 12/18] cpu: Change default for
 CPUClass::get_paging_enabled()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?UTF-8?B?RsOkcmJlcg==?= <afaerber@suse.de>
Cc: qiaonuohan@cn.fujitsu.com, qemu-devel@nongnu.org

On Sun,  9 Jun 2013 18:10:41 +0200
Andreas F=C3=A4rber <afaerber@suse.de> wrote:

> qemu_get_guest_memory_mapping() uses cpu_paging_enabled() to determine
> whether to use cpu_get_memory_mapping() to return mappings or whether to
> fall back to a simple identity map.
>=20
> Since by default CPUClass::get_memory_mapping() is not implemented,
> change the default to false to use the identity map by default.
>=20
> Signed-off-by: Andreas F=C3=A4rber <afaerber@suse.de>

Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>

> ---
>  qom/cpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/qom/cpu.c b/qom/cpu.c
> index b25fbc9..dba4a11 100644
> --- a/qom/cpu.c
> +++ b/qom/cpu.c
> @@ -59,7 +59,7 @@ bool cpu_paging_enabled(const CPUState *cpu)
> =20
>  static bool cpu_common_get_paging_enabled(const CPUState *cpu)
>  {
> -    return true;
> +    return false;
>  }
> =20
>  void cpu_get_memory_mapping(CPUState *cpu, MemoryMappingList *list,