qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: KVM devel mailing list <kvm@vger.kernel.org>,
	Juan Quintela <quintela@redhat.com>,
	"Jordan Justen (Intel address)" <jordan.l.justen@intel.com>,
	seabios@seabios.org, qemu-devel <qemu-devel@nongnu.org>,
	Kevin O'Connor <kevin@koconnor.net>,
	ddutile@redhat.com, Anthony Liguori <anthony@codemonkey.ws>,
	dwmw2@infradead.org
Subject: Re: [Qemu-devel] KVM call agenda for 2013-06-11
Date: Tue, 11 Jun 2013 22:15:24 +0300	[thread overview]
Message-ID: <20130611191524.GA3098@redhat.com> (raw)
In-Reply-To: <51B76717.1030502@redhat.com>

On Tue, Jun 11, 2013 at 08:06:15PM +0200, Laszlo Ersek wrote:
> On 06/11/13 17:45, Michael S. Tsirkin wrote:
> 
> > To summarize, there's a concensus now that generating ACPI
> > tables in QEMU is a good idea.
> > 
> > Two issues that need to be addressed:
> > - original patches break cross-version migration. Need to fix that.
> > 
> > - Anthony requested that patchset is merged together with
> >   some new feature. I'm not sure the reasoning is clear:
> >   current a version intentionally generates tables
> >   that are bug for bug compatible with seabios,
> >   to simplify testing.
> 
> Sorry about not following the series more closely -- is there now a qemu
> interface available that allows any firmware just take the tables, maybe
> to fix them up blindly / algorithmically, and to install them?

Yes.

> IOW, is the interface at such a point that in OVMF we could start
> looking throwing out specific code, in favor of implementing the generic
> fw-side algorithm?
> 
> >   It seems clear we have users for this such as
> >   hotplug of devices behind pci bridges, so
> >   why keep the infrastructure out of tree?
> > 
> >   Looking for something additional, smaller as the hotplug patch
> >   is a bit big, so might delay merging.
> > 
> > 
> > Going forward - would we want to move
> > smbios as well? Everyone seems to think it's a
> > good idea.
> 
> I think the current fw_cfg interface for SMBIOS tables is already good
> enough to save a lot of work in OVMF. Namely, if all required tables
> were generated (table template + field-wise patching) in qemu, and then
> all exported over fw_cfg as verbatim tables, my SMBIOS series currently
> pending for OVMF should be able to install them.
> 
> This would save OVMF the coding of templates (and any necessary
> patching) for types 3, 4 (especially nasty), 9, 16, 17, 19, and 32.
> (Basically "all except type 0 and type 1", which are already implemented
> (but verbatim tables from qemu would take priority even for type 0 and
> type 1). Type 7 can be left out apparently; IIRC dmidecode doesn't
> report it even under SeaBIOS.)
> 
> I'm not implying anyone should start working on this (myself included
> :)), but yeah, moving SMBIOS would save work in OVMF. (Provided there
> was any reason to support said SMBIOS tables in OVMF :))
> 
> Thanks,
> Laszlo

  reply	other threads:[~2013-06-11 19:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-04 13:24 [Qemu-devel] KVM call agenda for 2013-06-11 Michael S. Tsirkin
2013-06-10 16:50 ` Michael S. Tsirkin
2013-06-11 15:45 ` Michael S. Tsirkin
2013-06-11 18:06   ` Laszlo Ersek
2013-06-11 19:15     ` Michael S. Tsirkin [this message]
2013-06-11 18:38   ` Anthony Liguori
2013-06-11 19:22     ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130611191524.GA3098@redhat.com \
    --to=mst@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=ddutile@redhat.com \
    --cc=dwmw2@infradead.org \
    --cc=jordan.l.justen@intel.com \
    --cc=kevin@koconnor.net \
    --cc=kvm@vger.kernel.org \
    --cc=lersek@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=seabios@seabios.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).