* [Qemu-devel] [PATCH for-1.5] ppc: do not register IABR SPR twice for 603e
@ 2013-05-11 19:03 Hervé Poussineau
2013-05-20 18:17 ` Hervé Poussineau
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Hervé Poussineau @ 2013-05-11 19:03 UTC (permalink / raw)
To: qemu-devel; +Cc: Hervé Poussineau, qemu-ppc, Alexander Graf
IABR SPR is already registered in gen_spr_603(), called from init_proc_603E().
Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
---
target-ppc/translate_init.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
index 6feb62a..248d3e0 100644
--- a/target-ppc/translate_init.c
+++ b/target-ppc/translate_init.c
@@ -4980,11 +4980,6 @@ static void init_proc_603E (CPUPPCState *env)
SPR_NOACCESS, SPR_NOACCESS,
&spr_read_generic, &spr_write_generic,
0x00000000);
- /* XXX : not implemented */
- spr_register(env, SPR_IABR, "IABR",
- SPR_NOACCESS, SPR_NOACCESS,
- &spr_read_generic, &spr_write_generic,
- 0x00000000);
/* Memory management */
gen_low_BATs(env);
gen_6xx_7xx_soft_tlb(env, 64, 2);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH for-1.5] ppc: do not register IABR SPR twice for 603e
2013-05-11 19:03 [Qemu-devel] [PATCH for-1.5] ppc: do not register IABR SPR twice for 603e Hervé Poussineau
@ 2013-05-20 18:17 ` Hervé Poussineau
2013-06-11 21:42 ` [Qemu-devel] [Qemu-stable] " mdroth
2013-06-15 21:00 ` [Qemu-devel] " Andreas Färber
2013-06-18 15:38 ` Alexander Graf
2 siblings, 1 reply; 7+ messages in thread
From: Hervé Poussineau @ 2013-05-20 18:17 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-ppc, Alexander Graf, qemu-stable
Ping.
This should be IMO committed to stable, as it fixes a crash with
qemu-system-ppc -M prep -cpu 603e
Hervé
Hervé Poussineau a écrit :
> IABR SPR is already registered in gen_spr_603(), called from init_proc_603E().
>
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
> ---
> target-ppc/translate_init.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
> index 6feb62a..248d3e0 100644
> --- a/target-ppc/translate_init.c
> +++ b/target-ppc/translate_init.c
> @@ -4980,11 +4980,6 @@ static void init_proc_603E (CPUPPCState *env)
> SPR_NOACCESS, SPR_NOACCESS,
> &spr_read_generic, &spr_write_generic,
> 0x00000000);
> - /* XXX : not implemented */
> - spr_register(env, SPR_IABR, "IABR",
> - SPR_NOACCESS, SPR_NOACCESS,
> - &spr_read_generic, &spr_write_generic,
> - 0x00000000);
> /* Memory management */
> gen_low_BATs(env);
> gen_6xx_7xx_soft_tlb(env, 64, 2);
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [Qemu-stable] [PATCH for-1.5] ppc: do not register IABR SPR twice for 603e
2013-05-20 18:17 ` Hervé Poussineau
@ 2013-06-11 21:42 ` mdroth
2013-06-15 18:19 ` Hervé Poussineau
2013-06-15 18:20 ` Hervé Poussineau
0 siblings, 2 replies; 7+ messages in thread
From: mdroth @ 2013-06-11 21:42 UTC (permalink / raw)
To: Hervé Poussineau; +Cc: qemu-stable, qemu-ppc, qemu-devel, Alexander Graf
On Mon, May 20, 2013 at 08:17:47PM +0200, Hervé Poussineau wrote:
> Ping.
> This should be IMO committed to stable, as it fixes a crash with
> qemu-system-ppc -M prep -cpu 603e
Ping^2. Looking to pull this in for 1.5.1
>
> Hervé
>
> Hervé Poussineau a écrit :
> >IABR SPR is already registered in gen_spr_603(), called from init_proc_603E().
> >
> >Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
> >---
> > target-ppc/translate_init.c | 5 -----
> > 1 file changed, 5 deletions(-)
> >
> >diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
> >index 6feb62a..248d3e0 100644
> >--- a/target-ppc/translate_init.c
> >+++ b/target-ppc/translate_init.c
> >@@ -4980,11 +4980,6 @@ static void init_proc_603E (CPUPPCState *env)
> > SPR_NOACCESS, SPR_NOACCESS,
> > &spr_read_generic, &spr_write_generic,
> > 0x00000000);
> >- /* XXX : not implemented */
> >- spr_register(env, SPR_IABR, "IABR",
> >- SPR_NOACCESS, SPR_NOACCESS,
> >- &spr_read_generic, &spr_write_generic,
> >- 0x00000000);
> > /* Memory management */
> > gen_low_BATs(env);
> > gen_6xx_7xx_soft_tlb(env, 64, 2);
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [Qemu-stable] [PATCH for-1.5] ppc: do not register IABR SPR twice for 603e
2013-06-11 21:42 ` [Qemu-devel] [Qemu-stable] " mdroth
@ 2013-06-15 18:19 ` Hervé Poussineau
2013-06-15 18:20 ` Hervé Poussineau
1 sibling, 0 replies; 7+ messages in thread
From: Hervé Poussineau @ 2013-06-15 18:19 UTC (permalink / raw)
To: mdroth; +Cc: qemu-stable, qemu-ppc, qemu-devel, Alexander Graf
mdroth a écrit :
> On Mon, May 20, 2013 at 08:17:47PM +0200, Hervé Poussineau wrote:
>> Ping.
>> This should be IMO committed to stable, as it fixes a crash with
>> qemu-system-ppc -M prep -cpu 603e
>
> Ping^2. Looking to pull this in for 1.5.1
Ping^3
>
>> Hervé
>>
>> Hervé Poussineau a écrit :
>>> IABR SPR is already registered in gen_spr_603(), called from init_proc_603E().
>>>
>>> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
>>> ---
>>> target-ppc/translate_init.c | 5 -----
>>> 1 file changed, 5 deletions(-)
>>>
>>> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
>>> index 6feb62a..248d3e0 100644
>>> --- a/target-ppc/translate_init.c
>>> +++ b/target-ppc/translate_init.c
>>> @@ -4980,11 +4980,6 @@ static void init_proc_603E (CPUPPCState *env)
>>> SPR_NOACCESS, SPR_NOACCESS,
>>> &spr_read_generic, &spr_write_generic,
>>> 0x00000000);
>>> - /* XXX : not implemented */
>>> - spr_register(env, SPR_IABR, "IABR",
>>> - SPR_NOACCESS, SPR_NOACCESS,
>>> - &spr_read_generic, &spr_write_generic,
>>> - 0x00000000);
>>> /* Memory management */
>>> gen_low_BATs(env);
>>> gen_6xx_7xx_soft_tlb(env, 64, 2);
>>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [Qemu-stable] [PATCH for-1.5] ppc: do not register IABR SPR twice for 603e
2013-06-11 21:42 ` [Qemu-devel] [Qemu-stable] " mdroth
2013-06-15 18:19 ` Hervé Poussineau
@ 2013-06-15 18:20 ` Hervé Poussineau
1 sibling, 0 replies; 7+ messages in thread
From: Hervé Poussineau @ 2013-06-15 18:20 UTC (permalink / raw)
To: mdroth; +Cc: qemu-stable, qemu-ppc, qemu-devel, Alexander Graf
mdroth a écrit :
> On Mon, May 20, 2013 at 08:17:47PM +0200, Hervé Poussineau wrote:
>> Ping.
>> This should be IMO committed to stable, as it fixes a crash with
>> qemu-system-ppc -M prep -cpu 603e
>
> Ping^2. Looking to pull this in for 1.5.1
Ping^3
>> Hervé Poussineau a écrit :
>>> IABR SPR is already registered in gen_spr_603(), called from init_proc_603E().
>>>
>>> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
>>> ---
>>> target-ppc/translate_init.c | 5 -----
>>> 1 file changed, 5 deletions(-)
>>>
>>> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
>>> index 6feb62a..248d3e0 100644
>>> --- a/target-ppc/translate_init.c
>>> +++ b/target-ppc/translate_init.c
>>> @@ -4980,11 +4980,6 @@ static void init_proc_603E (CPUPPCState *env)
>>> SPR_NOACCESS, SPR_NOACCESS,
>>> &spr_read_generic, &spr_write_generic,
>>> 0x00000000);
>>> - /* XXX : not implemented */
>>> - spr_register(env, SPR_IABR, "IABR",
>>> - SPR_NOACCESS, SPR_NOACCESS,
>>> - &spr_read_generic, &spr_write_generic,
>>> - 0x00000000);
>>> /* Memory management */
>>> gen_low_BATs(env);
>>> gen_6xx_7xx_soft_tlb(env, 64, 2);
>>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH for-1.5] ppc: do not register IABR SPR twice for 603e
2013-05-11 19:03 [Qemu-devel] [PATCH for-1.5] ppc: do not register IABR SPR twice for 603e Hervé Poussineau
2013-05-20 18:17 ` Hervé Poussineau
@ 2013-06-15 21:00 ` Andreas Färber
2013-06-18 15:38 ` Alexander Graf
2 siblings, 0 replies; 7+ messages in thread
From: Andreas Färber @ 2013-06-15 21:00 UTC (permalink / raw)
To: Hervé Poussineau; +Cc: qemu-ppc, qemu-devel, Alexander Graf
Am 11.05.2013 21:03, schrieb Hervé Poussineau:
> IABR SPR is already registered in gen_spr_603(), called from init_proc_603E().
>
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
Confirmed,
Reviewed-by: Andreas Färber <afaerber@suse.de>
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH for-1.5] ppc: do not register IABR SPR twice for 603e
2013-05-11 19:03 [Qemu-devel] [PATCH for-1.5] ppc: do not register IABR SPR twice for 603e Hervé Poussineau
2013-05-20 18:17 ` Hervé Poussineau
2013-06-15 21:00 ` [Qemu-devel] " Andreas Färber
@ 2013-06-18 15:38 ` Alexander Graf
2 siblings, 0 replies; 7+ messages in thread
From: Alexander Graf @ 2013-06-18 15:38 UTC (permalink / raw)
To: Hervé Poussineau; +Cc: qemu-ppc, qemu-devel
On 11.05.2013, at 21:03, Hervé Poussineau wrote:
> IABR SPR is already registered in gen_spr_603(), called from init_proc_603E().
>
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
Thanks, applied to ppc-next. Sorry for the long delay - I was on vacation :)
Alex
> ---
> target-ppc/translate_init.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
> index 6feb62a..248d3e0 100644
> --- a/target-ppc/translate_init.c
> +++ b/target-ppc/translate_init.c
> @@ -4980,11 +4980,6 @@ static void init_proc_603E (CPUPPCState *env)
> SPR_NOACCESS, SPR_NOACCESS,
> &spr_read_generic, &spr_write_generic,
> 0x00000000);
> - /* XXX : not implemented */
> - spr_register(env, SPR_IABR, "IABR",
> - SPR_NOACCESS, SPR_NOACCESS,
> - &spr_read_generic, &spr_write_generic,
> - 0x00000000);
> /* Memory management */
> gen_low_BATs(env);
> gen_6xx_7xx_soft_tlb(env, 64, 2);
> --
> 1.7.10.4
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-06-18 15:38 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-11 19:03 [Qemu-devel] [PATCH for-1.5] ppc: do not register IABR SPR twice for 603e Hervé Poussineau
2013-05-20 18:17 ` Hervé Poussineau
2013-06-11 21:42 ` [Qemu-devel] [Qemu-stable] " mdroth
2013-06-15 18:19 ` Hervé Poussineau
2013-06-15 18:20 ` Hervé Poussineau
2013-06-15 21:00 ` [Qemu-devel] " Andreas Färber
2013-06-18 15:38 ` Alexander Graf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).