From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59870)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1UmWLF-0004TM-PE
	for qemu-devel@nongnu.org; Tue, 11 Jun 2013 17:43:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1UmWLD-0003GD-Pk
	for qemu-devel@nongnu.org; Tue, 11 Jun 2013 17:43:01 -0400
Sender: fluxion <flukshun@gmail.com>
Date: Tue, 11 Jun 2013 16:42:41 -0500
From: mdroth <mdroth@linux.vnet.ibm.com>
Message-ID: <20130611214241.GA13030@vm>
References: <1368299031-17587-1-git-send-email-hpoussin@reactos.org>
	<519A68CB.2040406@reactos.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <519A68CB.2040406@reactos.org>
Subject: Re: [Qemu-devel] [Qemu-stable] [PATCH for-1.5] ppc: do not register
	IABR SPR	twice for 603e
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?iso-8859-1?Q?Herv=E9?= Poussineau <hpoussin@reactos.org>
Cc: qemu-stable@nongnu.org, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>

On Mon, May 20, 2013 at 08:17:47PM +0200, Hervé Poussineau wrote:
> Ping.
> This should be IMO committed to stable, as it fixes a crash with
> qemu-system-ppc -M prep -cpu 603e

Ping^2. Looking to pull this in for 1.5.1

> 
> Hervé
> 
> Hervé Poussineau a écrit :
> >IABR SPR is already registered in gen_spr_603(), called from init_proc_603E().
> >
> >Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
> >---
> > target-ppc/translate_init.c |    5 -----
> > 1 file changed, 5 deletions(-)
> >
> >diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
> >index 6feb62a..248d3e0 100644
> >--- a/target-ppc/translate_init.c
> >+++ b/target-ppc/translate_init.c
> >@@ -4980,11 +4980,6 @@ static void init_proc_603E (CPUPPCState *env)
> >                  SPR_NOACCESS, SPR_NOACCESS,
> >                  &spr_read_generic, &spr_write_generic,
> >                  0x00000000);
> >-    /* XXX : not implemented */
> >-    spr_register(env, SPR_IABR, "IABR",
> >-                 SPR_NOACCESS, SPR_NOACCESS,
> >-                 &spr_read_generic, &spr_write_generic,
> >-                 0x00000000);
> >     /* Memory management */
> >     gen_low_BATs(env);
> >     gen_6xx_7xx_soft_tlb(env, 64, 2);
> 
>