From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37806)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Uml1c-0004uB-NE
	for qemu-devel@nongnu.org; Wed, 12 Jun 2013 09:23:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Uml1Y-0003Fb-3G
	for qemu-devel@nongnu.org; Wed, 12 Jun 2013 09:23:44 -0400
Received: from mx1.redhat.com ([209.132.183.28]:27918)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Uml1X-0003FW-Rm
	for qemu-devel@nongnu.org; Wed, 12 Jun 2013 09:23:40 -0400
Date: Wed, 12 Jun 2013 09:23:37 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20130612092337.181e9073@redhat.com>
In-Reply-To: <51B875D0.9070202@redhat.com>
References: <1371037877-14821-1-git-send-email-kraxel@redhat.com>
	<20130612081815.6fbd86c1@redhat.com> <51B875D0.9070202@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] console: extend screendump monitor cmd
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "Anthony Liguori (maintainer:Graphics)" <aliguori@us.ibm.com>, Amos <akong@redhat.com>, qemu-devel@nongnu.org, "Markus Armbruster (supporter:QAPI Schema)" <armbru@redhat.com>

On Wed, 12 Jun 2013 15:21:20 +0200
Gerd Hoffmann <kraxel@redhat.com> wrote:

>   Hi,
> 
> >> -{ 'command': 'screendump', 'data': {'filename': 'str'} }
> >> +{ 'command': 'screendump', 'data': {'filename': 'str',
> >> +                                    '*device' : 'str'} }
> > 
> > We can't add new optional parameters to QMP commands because it's
> > currently impossible for mngt apps to discover them.
> > 
> > We have two options: 1. add this as a new command or 2. wait for
> > full schema introspection (which we might get for 1.6).
> 
> "might get" sounds like it isn't a save bet, so I guess I better should
> go for option (1) ...

Amos, do you think we'll get it for 1.6?