From: Stefan Hajnoczi <stefanha@gmail.com>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Jeffrey Cody <jcody@redhat.com>,
qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] vmdk: refuse to open higher version than supported
Date: Thu, 13 Jun 2013 10:38:08 +0200 [thread overview]
Message-ID: <20130613083808.GE2633@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1371093689-18228-1-git-send-email-famz@redhat.com>
On Thu, Jun 13, 2013 at 11:21:29AM +0800, Fam Zheng wrote:
> Refuse to open higher version for safety.
>
> Although we try to be compatible with published VMDK spec, VMware has
> newer version from ESXi 5.1 exported OVF/OVA, which we have no knowledge
> what's changed in it. And it is very likely to have more new versions in
> the future, so it's not safe to open them blindly.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
>
> ---
>
> v2: Report error and return -ENOTSUP.
>
> ---
> block/vmdk.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
next prev parent reply other threads:[~2013-06-13 8:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-13 3:21 [Qemu-devel] [PATCH v2] vmdk: refuse to open higher version than supported Fam Zheng
2013-06-13 8:38 ` Stefan Hajnoczi [this message]
2013-06-24 6:19 ` Fam Zheng
2013-06-24 9:18 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130613083808.GE2633@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).