From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45088) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Un32r-0003ca-JG for qemu-devel@nongnu.org; Thu, 13 Jun 2013 04:38:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Un32q-0002Se-54 for qemu-devel@nongnu.org; Thu, 13 Jun 2013 04:38:13 -0400 Received: from mail-wg0-x22d.google.com ([2a00:1450:400c:c00::22d]:35262) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Un32p-0002ST-UY for qemu-devel@nongnu.org; Thu, 13 Jun 2013 04:38:12 -0400 Received: by mail-wg0-f45.google.com with SMTP id j13so2443369wgh.12 for ; Thu, 13 Jun 2013 01:38:11 -0700 (PDT) Date: Thu, 13 Jun 2013 10:38:08 +0200 From: Stefan Hajnoczi Message-ID: <20130613083808.GE2633@stefanha-thinkpad.redhat.com> References: <1371093689-18228-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1371093689-18228-1-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] vmdk: refuse to open higher version than supported List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Kevin Wolf , Jeffrey Cody , qemu-devel@nongnu.org, stefanha@redhat.com On Thu, Jun 13, 2013 at 11:21:29AM +0800, Fam Zheng wrote: > Refuse to open higher version for safety. > > Although we try to be compatible with published VMDK spec, VMware has > newer version from ESXi 5.1 exported OVF/OVA, which we have no knowledge > what's changed in it. And it is very likely to have more new versions in > the future, so it's not safe to open them blindly. > > Signed-off-by: Fam Zheng > > --- > > v2: Report error and return -ENOTSUP. > > --- > block/vmdk.c | 9 +++++++++ > 1 file changed, 9 insertions(+) Reviewed-by: Stefan Hajnoczi