From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36632) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UoAMt-0007JX-V9 for qemu-devel@nongnu.org; Sun, 16 Jun 2013 06:39:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UoAMp-0002wr-Ua for qemu-devel@nongnu.org; Sun, 16 Jun 2013 06:39:31 -0400 Date: Sun, 16 Jun 2013 20:20:08 +1000 From: David Gibson Message-ID: <20130616102008.GA26552@voom.fritz.box> References: <1368764711-13763-1-git-send-email-david@gibson.dropbear.id.au> <5195DF61.3070502@suse.de> <437ECAF8-6CF1-4015-96FA-F1CE0400A968@suse.de> <51BB2890.7070502@suse.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="EVF5PPMfhYS0aIcm" Content-Disposition: inline In-Reply-To: <51BB2890.7070502@suse.de> Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc: Change default machine for 64-bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: aurel@aurel32.net, aliguori@us.ibm.com, qemu-ppc@nongnu.org, Alexander Graf , qemu-devel@nongnu.org --EVF5PPMfhYS0aIcm Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 14, 2013 at 04:28:32PM +0200, Andreas F=E4rber wrote: > Am 13.06.2013 15:49, schrieb Alexander Graf: > > On 17.05.2013, at 09:42, Andreas F=E4rber wrote: > >> Am 17.05.2013 06:25, schrieb David Gibson: > >>> Currently, for qemu-system-ppc64, the default machine type is 'mac99'. > >>> Since the mac99 machine is not being actively maintained, and shows q= uite > >>> a few signs of bitrot, > >> > >> Please be more specific than making such general claims in a commit > >> message! As the default machine it certainly compiles, so where are you > >> seeing bitrot? The DEC bridge cleanup that I once started kind of > >> depends on the PCI cleanup you recently looked into. > >=20 > > The mac99 machine for 64bit is actually worse than anything bitrot coul= d give you. It emulates a machine that in its form never possibly could hav= e existed in real hardware, which makes it very fragile and dependent on th= e guest's mercy to handle this gracefully. >=20 > Still we should put that in the commit message and not "shows quite a > few signs of bitrot". Bitrot is what gus.c and cs4231a.c may have > endured while not being compiled in or those disabled DPRINTF()s > sprinkled all over the code base. >=20 > Further, David is looking at this from a biased perspective: -M pseries > is best maintained (apart from e500) ppc target, but it doesn't work > with PR KVM (not on my box anyway). But neither does mac99 on KVM due to > page sizes or something IIRC. However under TCG either is okay with the > guests I've seen so far and they all compile warning-free. >=20 > pseries used to hang, that is no longer the case, it just doesn't do > anything now - still need to debug how to improve that. >=20 > > Given the current state and amount of development on the pseries > target, I think it makes sense to declare that as the default for > qemu-system-ppc64. >=20 > No disagreement there then. Well, I've sent an updated version with a more accurate commit message to Alex Graf. It's also at git://github.com/dgibson/qemu.git, ppc-next branch. I do think that pseries is a better choice than mac99, but I tend to agree with Peter Maydell that the whole notion of a default machine is a bit silly. In any case, since I'm no longer actively working on qemu ppc, I don't really care enough to argue about it, so I guess it's up to Alex. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --EVF5PPMfhYS0aIcm Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) iEYEARECAAYFAlG9kVgACgkQaILKxv3ab8YN7QCcDSs5qX/kmLDcAEml+sWDkpAK rV4AoJHcONmZ52wZNfb3cKUKRu+jpcZ0 =LcDe -----END PGP SIGNATURE----- --EVF5PPMfhYS0aIcm--