From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48444)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UoZ4S-00007e-9Y
	for qemu-devel@nongnu.org; Mon, 17 Jun 2013 09:02:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UoZ4P-0005mf-HJ
	for qemu-devel@nongnu.org; Mon, 17 Jun 2013 09:02:08 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58540)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UoZ4P-0005mN-94
	for qemu-devel@nongnu.org; Mon, 17 Jun 2013 09:02:05 -0400
Date: Mon, 17 Jun 2013 09:01:58 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20130617090158.66667be9@redhat.com>
In-Reply-To: <20130614054641.GA30532@t430s.nay.redhat.com>
References: <20130531123117.GA8400@t430s.nay.redhat.com>
	<20130614054641.GA30532@t430s.nay.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 1/2] ps2: add support of auto-repeat
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amos Kong <akong@redhat.com>
Cc: peter.maydell@linaro.org, Anthony Liguori <aliguori@us.ibm.com>, lilei@linux.vnet.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, kraxel@redhat.com, Paolo Bonzini <pbonzini@redhat.com>, lersek@redhat.com

On Fri, 14 Jun 2013 13:46:41 +0800
Amos Kong <akong@redhat.com> wrote:

> On Fri, May 31, 2013 at 08:31:17PM +0800, Amos Kong wrote:
> > On Thu, May 30, 2013 at 11:48:46AM -0500, Anthony Liguori wrote:
> > > Amos Kong <akong@redhat.com> writes:
> 
> 
> > > > diff --git a/hw/input/ps2.c b/hw/input/ps2.c
> > > > index 3412079..8adbb4a 100644
> > > > --- a/hw/input/ps2.c
> > > > +++ b/hw/input/ps2.c
> > > > @@ -94,6 +94,10 @@ typedef struct {
> > > >      int translate;
> > > >      int scancode_set; /* 1=XT, 2=AT, 3=PS/2 */
> > > >      int ledstate;
> > > > +    int repeat_period; /* typematic period, ms */
> > > > +    int repeat_delay; /* typematic delay, ms */
> > > > +    int repeat_key; /* keycode to repeat */
> > > > +    QEMUTimer *repeat_timer;
> > > 
> > > This state needs to be migrated, no?  I suspect it can/should be done
> > > via a subsection too.
> > 
> > It sounds only reasonable for 'sendkey' command. We want to repeat one
> > key for 100 times, the key should be continaully repeated in the dest
> > vm until it reaches to 100 times.
> > 
> > For implement this, we should also migrate key_timer in ui/input.c,
> > then it will send a release event to ps2 queue when the key_timer
> > is expired. The bottom patch migrates repeat_timer & repeat_key,
> > where should we save key_timer for migration?
> 
> Luiz, any suggestion about migrate the key_timer in ui/input.c?

I don't have any. Maybe Markus or Juan can help (CC'ed).

> 
> We need to migrate it, then sendkey can continually work in dest vm
> until the timer is expired.
> 
> Thanks.