Re: [Qemu-devel] [PATCH] make screendump an async command

[Luiz Capitulino <lcapitulino@redhat.com>]

On Fri, 14 Jun 2013 19:55:21 -0400
Alon Levy <alevy@redhat.com> wrote:

> On Fri, 2013-06-14 at 13:21 -0500, Anthony Liguori wrote:
> > Alon Levy <alevy@redhat.com> writes:
> > 
> > > This fixes the broken screendump behavior for qxl devices in native mode
> > > since 81fb6f1504fb9ef71f2382f44af34756668296e8.
> > >
> > > Note: due to QAPI not generating async commands yet I had to remove the
> > > schema screendump definition.
> > >
> > > Related RHBZ: 973374
> > > This patch is not enough to fix said bz, with the linux qxl driver you get garbage still, just not out of date garbage.
> > >
> > > Signed-off-by: Alon Levy <alevy@redhat.com>
> > 
> > Async commands are badly broken with respect to error handling.
> 
> Are there any ideas on how this should work? From the user perspective
> nothing changes, so this is an internal qemu design issue afaict.
> 
> > 
> > This needs to be done after we get the new QMP server.
> 
> Is there any ETA on this? I'm not pressuring, I'm just trying to figure
> out if it is eminent or else I'll add a temporary patch to the
> downstream (which is what I'm trying to avoid by sending this patch in
> the first place).

No ETA. We have to finish QAPI conversion work first (which is halted ATM)
_or_ we lazily port the missing conversions by doing error conversion
only _or_ we add some legacy mechanism to the new QMP server.

More importantly though, IIRC we have agreed on not having async commands
at all. All async stuff should be done with command plus event.