From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43418) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UoX5P-00018l-6H for qemu-devel@nongnu.org; Mon, 17 Jun 2013 06:55:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UoX5K-0004d0-Bx for qemu-devel@nongnu.org; Mon, 17 Jun 2013 06:54:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46691) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UoX5J-0004ck-TO for qemu-devel@nongnu.org; Mon, 17 Jun 2013 06:54:54 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5HAsqkd002224 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 17 Jun 2013 06:54:52 -0400 Date: Mon, 17 Jun 2013 11:54:49 +0100 From: "Richard W.M. Jones" Message-ID: <20130617105413.GC1882@redhat.com> References: <1371463763-25628-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1371463763-25628-1-git-send-email-famz@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] curl: refuse to open URL from HTTP server without range support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Kevin Wolf , qemu-devel@nongnu.org, stefanha@redhat.com On Mon, Jun 17, 2013 at 06:09:23PM +0800, Fam Zheng wrote: > + if (real_size >=3D strlen(accept_len) What's accept_len? This patch gives me a couple of compile errors: block/curl.c: In function =E2=80=98curl_header_cb=E2=80=99: block/curl.c:120:9: error: =E2=80=98real_size=E2=80=99 undeclared (first = use in this function) block/curl.c:120:9: note: each undeclared identifier is reported only onc= e for each function it appears in block/curl.c:120:29: error: =E2=80=98accept_len=E2=80=99 undeclared (firs= t use in this function) make: *** [block/curl.o] Error 1 Rich. --=20 Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rj= ones virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://people.redhat.com/~rjones/virt-df/