qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: laine@redhat.com, Amos Kong <akong@redhat.com>,
	qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v6] net: add support of mac-programming over macvtap in QEMU side
Date: Mon, 17 Jun 2013 11:15:20 -0400	[thread overview]
Message-ID: <20130617111520.5ce4d481@redhat.com> (raw)
In-Reply-To: <20130617151023.GA10817@redhat.com>

On Mon, 17 Jun 2013 18:10:23 +0300
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Mon, Jun 17, 2013 at 10:54:39AM -0400, Luiz Capitulino wrote:
> > On Mon, 17 Jun 2013 17:42:50 +0300
> > "Michael S. Tsirkin" <mst@redhat.com> wrote:
> > 
> > > > The 1000ms I talked about is *not* what the guest will see. If there are
> > > > events pending, the throttle API just queues the event and returns right
> > > > away. I'd even _guess_ that this is faster then emitting the event.
> > > 
> > > If the filter is not updated for 1000ms then that is guest visible:
> > > it is not getting packets with the new MAC.
> > 
> > Let me understand this better: the filter is going to be updated by
> > libvirt, is that correctly?
> 
> Exactly.
> 
> > If this is right, then I can understand where you came from, but how
> > can we possibly control how long it will take for libvirt to take
> > action?
> 
> We can't, it's a best effort, but that's also true for some NICs.
> At least let's not introduce an artificial delay there.

Got it. Okay, I think the flag is fine and won't ask for more evidence then.

Although I still wonder if we would do alright w/o the flag and w/o using
the throttle API...

  reply	other threads:[~2013-06-17 15:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-14  7:45 [Qemu-devel] [PATCH v6] net: add support of mac-programming over macvtap in QEMU side Amos Kong
2013-06-17 13:11 ` Luiz Capitulino
2013-06-17 13:21   ` Michael S. Tsirkin
2013-06-17 13:30     ` Luiz Capitulino
2013-06-17 14:20       ` Michael S. Tsirkin
2013-06-17 14:34         ` Luiz Capitulino
2013-06-17 14:42           ` Michael S. Tsirkin
2013-06-17 14:54             ` Luiz Capitulino
2013-06-17 15:03               ` Amos Kong
2013-06-17 15:10               ` Michael S. Tsirkin
2013-06-17 15:15                 ` Luiz Capitulino [this message]
2013-06-17 14:50   ` Amos Kong
2013-06-17 13:52 ` Michael S. Tsirkin
2013-06-18  1:59 ` Wenchao Xia
2013-06-18  3:00   ` Amos Kong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130617111520.5ce4d481@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=akong@redhat.com \
    --cc=laine@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).