From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60989)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Uob9S-0001hd-L1
	for qemu-devel@nongnu.org; Mon, 17 Jun 2013 11:15:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Uob9Q-00026f-AC
	for qemu-devel@nongnu.org; Mon, 17 Jun 2013 11:15:26 -0400
Received: from mx1.redhat.com ([209.132.183.28]:13224)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Uob9Q-00026R-0i
	for qemu-devel@nongnu.org; Mon, 17 Jun 2013 11:15:24 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5HFFN0Q005410
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 17 Jun 2013 11:15:23 -0400
Date: Mon, 17 Jun 2013 11:15:20 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20130617111520.5ce4d481@redhat.com>
In-Reply-To: <20130617151023.GA10817@redhat.com>
References: <1371195952-13922-1-git-send-email-akong@redhat.com>
	<20130617091127.444de556@redhat.com>
	<20130617132131.GB9383@redhat.com>
	<20130617093042.4e1d6566@redhat.com>
	<20130617142013.GC10085@redhat.com>
	<20130617103428.3a1d7db7@redhat.com>
	<20130617144250.GE10085@redhat.com>
	<20130617105439.11a90c42@redhat.com>
	<20130617151023.GA10817@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v6] net: add support of mac-programming
 over macvtap in QEMU side
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: laine@redhat.com, Amos Kong <akong@redhat.com>, qemu-devel@nongnu.org, stefanha@redhat.com

On Mon, 17 Jun 2013 18:10:23 +0300
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Mon, Jun 17, 2013 at 10:54:39AM -0400, Luiz Capitulino wrote:
> > On Mon, 17 Jun 2013 17:42:50 +0300
> > "Michael S. Tsirkin" <mst@redhat.com> wrote:
> > 
> > > > The 1000ms I talked about is *not* what the guest will see. If there are
> > > > events pending, the throttle API just queues the event and returns right
> > > > away. I'd even _guess_ that this is faster then emitting the event.
> > > 
> > > If the filter is not updated for 1000ms then that is guest visible:
> > > it is not getting packets with the new MAC.
> > 
> > Let me understand this better: the filter is going to be updated by
> > libvirt, is that correctly?
> 
> Exactly.
> 
> > If this is right, then I can understand where you came from, but how
> > can we possibly control how long it will take for libvirt to take
> > action?
> 
> We can't, it's a best effort, but that's also true for some NICs.
> At least let's not introduce an artificial delay there.

Got it. Okay, I think the flag is fine and won't ask for more evidence then.

Although I still wonder if we would do alright w/o the flag and w/o using
the throttle API...