From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42103) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UoYa9-00021C-LU for qemu-devel@nongnu.org; Mon, 17 Jun 2013 08:30:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UoYa4-0004A6-ML for qemu-devel@nongnu.org; Mon, 17 Jun 2013 08:30:49 -0400 Received: from mail-we0-x235.google.com ([2a00:1450:400c:c03::235]:65098) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UoYa4-00049n-DP for qemu-devel@nongnu.org; Mon, 17 Jun 2013 08:30:44 -0400 Received: by mail-we0-f181.google.com with SMTP id p58so2258915wes.40 for ; Mon, 17 Jun 2013 05:30:43 -0700 (PDT) Date: Mon, 17 Jun 2013 14:30:40 +0200 From: Stefan Hajnoczi Message-ID: <20130617123040.GA30145@stefanha-thinkpad.redhat.com> References: <1368202225-45798-1-git-send-email-i.mitsyanko@gmail.com> <1368202225-45798-3-git-send-email-i.mitsyanko@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [RFC 2/7] sd.c: introduce variable for trekking valid data List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: peter.crosthwaite@xilinx.com, Igor Mitsyanko , sw@weilnetz.de, aliguori@us.ibm.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, paul@codesourcery.com, stefanha@redhat.com, pbonzini@redhat.com, afaerber@suse.de On Fri, Jun 14, 2013 at 12:49:52PM +0100, Peter Maydell wrote: > On 10 May 2013 17:10, Igor Mitsyanko wrote: > > Initialize it appropriately when various commands are processed. > > "tracking", but the commit message doesn't match the > patch contents anyway -- should this patch have more > content from later patches, or be squashed into one of > them? > > > > > Signed-off-by: Igor Mitsyanko > > --- > > hw/sd/sd.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/hw/sd/sd.c b/hw/sd/sd.c > > index 1dd1331..775a55c 100644 > > --- a/hw/sd/sd.c > > +++ b/hw/sd/sd.c > > @@ -116,6 +116,7 @@ struct SDState { > > QEMUIOVector qiov; > > struct iovec iov; > > BlockDriverAIOCB *aiocb; > > + uint32_t transf_cnt; > > How does this work for migration -- are we guaranteed that > all outstanding AIO requests complete before we try to > migrate? Migration does bdrv_drain_all() to complete all pending requests (indirectly by pausing the guest in do_vm_stop()). Stefan