From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43184)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UoYfz-00055U-AO
	for qemu-devel@nongnu.org; Mon, 17 Jun 2013 08:36:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UoYfu-0005xw-OZ
	for qemu-devel@nongnu.org; Mon, 17 Jun 2013 08:36:51 -0400
Received: from mail-wg0-x230.google.com ([2a00:1450:400c:c00::230]:49058)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UoYfu-0005wQ-Hx
	for qemu-devel@nongnu.org; Mon, 17 Jun 2013 08:36:46 -0400
Received: by mail-wg0-f48.google.com with SMTP id f11so2325922wgh.27
	for <qemu-devel@nongnu.org>; Mon, 17 Jun 2013 05:36:45 -0700 (PDT)
Date: Mon, 17 Jun 2013 14:36:43 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130617123643.GC30145@stefanha-thinkpad.redhat.com>
References: <1369917299-5725-1-git-send-email-stefanha@redhat.com>
	<1369917299-5725-4-git-send-email-stefanha@redhat.com>
	<20130617034324.GA10271@localhost.nay.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130617034324.GA10271@localhost.nay.redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 03/11] block: add basic backup support
 to block driver
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>, dietmar@proxmox.com, imain@redhat.com, Paolo Bonzini <pbonzini@redhat.com>, xiawenc@linux.vnet.ibm.com, Eric Blake <eblake@redhat.com>

On Mon, Jun 17, 2013 at 11:43:24AM +0800, Fam Zheng wrote:
> > +    bdrv_iostatus_disable(target);
> > +    bdrv_delete(job->target);
> 
> drive-mirror has bdrv_close before deleting target, why don't we need
> one here?

Use the source, Luke! :)

void bdrv_delete(BlockDriverState *bs)
{
    assert(!bs->dev);
    assert(!bs->job);
    assert(!bs->in_use);

    bdrv_close(bs);

    /* remove from list, if necessary */
    bdrv_make_anon(bs);

    g_free(bs);
}

Stefan