From: Stefan Hajnoczi <stefanha@gmail.com>
To: Bas van Sisseren <bas@quarantainenet.nl>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, Qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] [slirp] fix -net user checks by reordering checks
Date: Mon, 17 Jun 2013 14:39:27 +0200 [thread overview]
Message-ID: <20130617123927.GD30145@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <51BEF5F4.5090309@quarantainenet.nl>
On Mon, Jun 17, 2013 at 01:41:40PM +0200, Bas van Sisseren wrote:
> On 04/06/13 14:26, Stefan Hajnoczi wrote:
> > On Mon, Jun 03, 2013 at 03:11:49PM +0200, Bas van Sisseren wrote:
> >> reorder slirp config options. first check the dns-server-address,
> >> then check the first-dhcp-address. the original code was comparing
> >> the first-dhcp-address with the default dns-server-address, not
> >> the configured dns-server-address.
> >>
> >> Signed-off-by: Bas van Sisseren <bas@quarantainenet.nl>
> >> ---
> >> net/slirp.c | 12 ++++++------
> >> 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>
> Hello qemu-devel list,
>
> The last reaction was 2 weeks ago. Do I need more reviews for inclusion of
> the patch?
Jan is/was probably just away because of LinuxCon Japan
(http://events.linuxfoundation.org/events/linuxcon-japan). I'm sure
he'll be back soon and your patch will make it in time for the QEMU 1.6
release.
Stefan
next prev parent reply other threads:[~2013-06-17 12:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 13:11 [Qemu-devel] [PATCH] [slirp] fix -net user checks by reordering checks Bas van Sisseren
2013-06-04 12:26 ` Stefan Hajnoczi
2013-06-17 11:41 ` Bas van Sisseren
2013-06-17 12:39 ` Stefan Hajnoczi [this message]
2013-06-18 13:31 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130617123927.GD30145@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=bas@quarantainenet.nl \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).