From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45278)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UoYof-0002Py-0D
	for qemu-devel@nongnu.org; Mon, 17 Jun 2013 08:45:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UoYoa-0000Ub-2R
	for qemu-devel@nongnu.org; Mon, 17 Jun 2013 08:45:48 -0400
Received: from mail-wi0-x22c.google.com ([2a00:1450:400c:c05::22c]:41955)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UoYoZ-0000US-Im
	for qemu-devel@nongnu.org; Mon, 17 Jun 2013 08:45:43 -0400
Received: by mail-wi0-f172.google.com with SMTP id c10so2242795wiw.5
	for <qemu-devel@nongnu.org>; Mon, 17 Jun 2013 05:45:42 -0700 (PDT)
Date: Mon, 17 Jun 2013 14:45:39 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130617124539.GE30145@stefanha-thinkpad.redhat.com>
References: <1370606325-10680-1-git-send-email-stefanha@redhat.com>
	<1370606325-10680-22-git-send-email-stefanha@redhat.com>
	<CAFEAcA9F8vmhP1PTGuzi5sxbTtg3RW4_j-swmVZG+RNZHnYAWA@mail.gmail.com>
	<CAFEAcA_Sj8oa=0XNmKapNkz7coCvZ6-oanM1MmMtHAoRX63jaA@mail.gmail.com>
	<87ppvopncr.fsf@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87ppvopncr.fsf@codemonkey.ws>
Subject: Re: [Qemu-devel] [PULL 21/26] ide-test: Add FLUSH CACHE test case
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

On Fri, Jun 14, 2013 at 01:18:44PM -0500, Anthony Liguori wrote:
> Peter Maydell <peter.maydell@linaro.org> writes:
> 
> > On 14 June 2013 18:54, Peter Maydell <peter.maydell@linaro.org> wrote:
> >> On 7 June 2013 12:58, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> >>> From: Kevin Wolf <kwolf@redhat.com>
> >>>
> >>> This checks in particular that BSY is set while the flush request is in
> >>> flight.
> >>
> >> This test doesn't seem to pass.
> >
> >> ERROR:/home/petmay01/linaro/qemu-from-laptop/qemu/tests/ide-test.c:460:test_flush:
> >> assertion failed ((data) & (BSY | DF | ERR | DRQ) == 0): (0x00000080
> >> == 0x00000000)
> >
> > ...fixed by http://patchwork.ozlabs.org/patch/250334/
> 
> I'm testing it myself now.  Since it's already in the block tree, I'll
> push it directly as it's blocking my queue.
> 
> Unless Kevin or Stefan are planning on sending a pull request today of
> course.

Thanks for merging mdroth's fix!

Stefan