From: Stefan Hajnoczi <stefanha@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 3/5] qcow2: Options to enable discard for freed clusters
Date: Mon, 17 Jun 2013 17:41:59 +0200 [thread overview]
Message-ID: <20130617154159.GD31444@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1371124063-12971-4-git-send-email-kwolf@redhat.com>
On Thu, Jun 13, 2013 at 01:47:41PM +0200, Kevin Wolf wrote:
> @@ -532,6 +548,16 @@ static int qcow2_open(BlockDriverState *bs, QDict *options, int flags)
> s->use_lazy_refcounts = qemu_opt_get_bool(opts, QCOW2_OPT_LAZY_REFCOUNTS,
> (s->compatible_features & QCOW2_COMPAT_LAZY_REFCOUNTS));
>
> + s->discard_passthrough[QCOW2_DISCARD_NEVER] = false,
comma instead of semicolon?
> @@ -187,6 +190,8 @@ typedef struct BDRVQcowState {
> int qcow_version;
> bool use_lazy_refcounts;
>
> + bool discard_passthrough[QCOW2_DISCARD_MAX];
> +
Neat solution to specifying discard behavior.
Stefan
next prev parent reply other threads:[~2013-06-17 15:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-13 11:47 [Qemu-devel] [PATCH 0/5] qcow2: Discard freed clusters Kevin Wolf
2013-06-13 11:47 ` [Qemu-devel] [PATCH 1/5] Revert "block: Disable driver-specific options for 1.5" Kevin Wolf
2013-06-13 11:47 ` [Qemu-devel] [PATCH 2/5] qcow2: Add refcount update reason to all callers Kevin Wolf
2013-06-13 11:47 ` [Qemu-devel] [PATCH 3/5] qcow2: Options to enable discard for freed clusters Kevin Wolf
2013-06-13 22:10 ` Paolo Bonzini
2013-06-14 8:31 ` Kevin Wolf
2013-06-14 14:16 ` Paolo Bonzini
2013-06-14 14:31 ` Kevin Wolf
2013-06-14 15:00 ` Paolo Bonzini
2013-06-17 15:41 ` Stefan Hajnoczi [this message]
2013-06-17 15:58 ` Kevin Wolf
2013-06-13 11:47 ` [Qemu-devel] [PATCH 4/5] qcow2: Batch discards Kevin Wolf
2013-06-17 15:45 ` Stefan Hajnoczi
2013-06-13 11:47 ` [Qemu-devel] [PATCH 5/5] block: Always enable discard on the protocol level Kevin Wolf
2013-06-13 22:06 ` Paolo Bonzini
2013-06-14 8:14 ` Kevin Wolf
2013-06-18 3:03 ` [Qemu-devel] [PATCH 0/5] qcow2: Discard freed clusters Wenchao Xia
2013-06-18 6:25 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130617154159.GD31444@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).