From: Amos Kong <akong@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/2] extend the macaddr space to 0xffffffff
Date: Tue, 18 Jun 2013 09:51:44 +0800 [thread overview]
Message-ID: <20130618015144.GA2562@amosk.info> (raw)
In-Reply-To: <20130617140403.GB10085@redhat.com>
On Mon, Jun 17, 2013 at 05:04:03PM +0300, Michael S. Tsirkin wrote:
> On Mon, Jun 17, 2013 at 09:35:11PM +0800, Amos Kong wrote:
> > Currently we only support to allocate 0xff mac-addresses,
> > if we start guest by pci-bridge/multiple-func, the macaddr
> > are not enough.
> >
> > This patch extends the mac-address space to 0xffffffff
> >
> > 52:54:00:00:00:00 ~ 52:54:ff:ff:ff:ff
> >
> > Signed-off-by: Amos Kong <akong@redhat.com>
>
>
> And then there's even more chance a user error
> (forgot to specify mac) will lead to broken
> LANs because of collisions.
>
> Why is it that whoever wants >256 NICs can't just
> specify the addresses explicitly?
We should lead user to use assigned mac, those two patches
are just considered for the lazy users ;)
--
Amos.
next prev parent reply other threads:[~2013-06-18 1:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 13:35 [Qemu-devel] [PATCH 0/2] fix macaddr allocation Amos Kong
2013-06-17 13:35 ` [Qemu-devel] [PATCH 1/2] avoid to allcate used macaddr to to new nic Amos Kong
2013-06-17 14:00 ` Michael S. Tsirkin
2013-06-18 2:05 ` Fam Zheng
2013-06-18 6:27 ` Michael S. Tsirkin
2013-06-17 13:35 ` [Qemu-devel] [PATCH 2/2] extend the macaddr space to 0xffffffff Amos Kong
2013-06-17 14:04 ` Michael S. Tsirkin
2013-06-18 1:51 ` Amos Kong [this message]
2013-06-18 6:19 ` Michael S. Tsirkin
2013-06-18 11:21 ` [Qemu-devel] [PATCH 0/2] fix macaddr allocation Stefan Hajnoczi
2013-06-18 12:39 ` Amos Kong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130618015144.GA2562@amosk.info \
--to=akong@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).