From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41791) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uol5L-0004lu-QU for qemu-devel@nongnu.org; Mon, 17 Jun 2013 21:51:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uol5L-00088v-1P for qemu-devel@nongnu.org; Mon, 17 Jun 2013 21:51:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46865) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uol5K-00088q-PY for qemu-devel@nongnu.org; Mon, 17 Jun 2013 21:51:50 -0400 Date: Tue, 18 Jun 2013 09:51:44 +0800 From: Amos Kong Message-ID: <20130618015144.GA2562@amosk.info> References: <1371476111-4449-1-git-send-email-akong@redhat.com> <1371476111-4449-3-git-send-email-akong@redhat.com> <20130617140403.GB10085@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130617140403.GB10085@redhat.com> Subject: Re: [Qemu-devel] [PATCH 2/2] extend the macaddr space to 0xffffffff List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, stefanha@redhat.com On Mon, Jun 17, 2013 at 05:04:03PM +0300, Michael S. Tsirkin wrote: > On Mon, Jun 17, 2013 at 09:35:11PM +0800, Amos Kong wrote: > > Currently we only support to allocate 0xff mac-addresses, > > if we start guest by pci-bridge/multiple-func, the macaddr > > are not enough. > > > > This patch extends the mac-address space to 0xffffffff > > > > 52:54:00:00:00:00 ~ 52:54:ff:ff:ff:ff > > > > Signed-off-by: Amos Kong > > > And then there's even more chance a user error > (forgot to specify mac) will lead to broken > LANs because of collisions. > > Why is it that whoever wants >256 NICs can't just > specify the addresses explicitly? We should lead user to use assigned mac, those two patches are just considered for the lazy users ;) -- Amos.