From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53591) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uom9x-0002xR-Eb for qemu-devel@nongnu.org; Mon, 17 Jun 2013 23:00:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uom9v-0003cN-0g for qemu-devel@nongnu.org; Mon, 17 Jun 2013 23:00:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51955) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uom9u-0003c8-LT for qemu-devel@nongnu.org; Mon, 17 Jun 2013 23:00:38 -0400 Date: Tue, 18 Jun 2013 11:00:18 +0800 From: Amos Kong Message-ID: <20130618030018.GA6038@amosk.info> References: <1371195952-13922-1-git-send-email-akong@redhat.com> <51BFBEEE.8060803@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <51BFBEEE.8060803@linux.vnet.ibm.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v6] net: add support of mac-programming over macvtap in QEMU side List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: mst@redhat.com, stefanha@redhat.com, qemu-devel@nongnu.org, laine@redhat.com, lcapitulino@redhat.com On Tue, Jun 18, 2013 at 09:59:10AM +0800, Wenchao Xia wrote: > =E4=BA=8E 2013-6-14 15:45, Amos Kong =E5=86=99=E9=81=93: > > Currently macvtap based macvlan device is working in promiscuous > > mode, we want to implement mac-programming over macvtap through > > Libvirt for better performance. > >=20 > > Design: > > QEMU notifies Libvirt when rx-filter config is changed in guest, > > then Libvirt query the rx-filter information by a monitor command, > > and sync the change to macvtap device. Related rx-filter config > > of the nic contains main mac, rx-mode items and vlan table. > >=20 > > This patch adds a QMP event to notify management of rx-filter change, > > and adds a monitor command for management to query rx-filter > > information. > >=20 > > Test: > > If we repeatedly add/remove vlan, and change macaddr of vlan > > interfaces in guest by a loop script. > >=20 > > Result: > > The events will flood the QMP client(management), management takes > > too much resource to process the events. > >=20 > > Event_throttle API (set rate to 1 ms) can avoid the events to flood > > QMP client, but it could cause an unexpected delay (~1ms), guests > > guests normally expect rx-filter updates immediately. > >=20 > > So we use a flag for each nic to avoid events flooding, the event > > is emitted once until the query command is executed. The flag > > implementation could not introduce unexpected delay. > >=20 > > There maybe exist an uncontrollable delay if we let Libvirt do the > > real change, guests normally expect rx-filter updates immediately. > > But it's another separate issue, we can investigate it when the > > work in Libvirt side is done. > >=20 > Hi, Amos > This patch is for the user case that guest use a macvtap device right= ? > could u add some document in commit message, so reader can understand > what it trying to do? I will add a single document later for it. docs/macprogramming-over-macvtap.txt Thanks. =20 > Wenchao Xia --=20 Amos.