From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36890)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1UopFh-0003SX-6t
	for qemu-devel@nongnu.org; Tue, 18 Jun 2013 02:18:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1UopFe-000729-Fl
	for qemu-devel@nongnu.org; Tue, 18 Jun 2013 02:18:49 -0400
Received: from mx1.redhat.com ([209.132.183.28]:65143)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1UopFe-000722-7q
	for qemu-devel@nongnu.org; Tue, 18 Jun 2013 02:18:46 -0400
Date: Tue, 18 Jun 2013 09:19:31 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20130618061931.GB23367@redhat.com>
References: <1371476111-4449-1-git-send-email-akong@redhat.com>
	<1371476111-4449-3-git-send-email-akong@redhat.com>
	<20130617140403.GB10085@redhat.com>
	<20130618015144.GA2562@amosk.info>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130618015144.GA2562@amosk.info>
Subject: Re: [Qemu-devel] [PATCH 2/2] extend the macaddr space to 0xffffffff
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amos Kong <akong@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, stefanha@redhat.com

On Tue, Jun 18, 2013 at 09:51:44AM +0800, Amos Kong wrote:
> On Mon, Jun 17, 2013 at 05:04:03PM +0300, Michael S. Tsirkin wrote:
> > On Mon, Jun 17, 2013 at 09:35:11PM +0800, Amos Kong wrote:
> > > Currently we only support to allocate 0xff mac-addresses,
> > > if we start guest by pci-bridge/multiple-func, the macaddr
> > > are not enough.
> > > 
> > > This patch extends the mac-address space to 0xffffffff
> > > 
> > > 52:54:00:00:00:00 ~ 52:54:ff:ff:ff:ff
> > > 
> > > Signed-off-by: Amos Kong <akong@redhat.com>
> > 
> > 
> > And then there's even more chance a user error
> > (forgot to specify mac) will lead to broken
> > LANs because of collisions.
> >
> > Why is it that whoever wants >256 NICs can't just
> > specify the addresses explicitly?
> 
> We should lead user to use assigned mac, those two patches
> are just considered for the lazy users ;)

Let's just fail address allocation once the low byte overflows.
If you want >256 NICs, specify MAC addresses.

> 
> -- 
> 			Amos.