From: Luiz Capitulino <lcapitulino@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
alevy@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd
Date: Tue, 18 Jun 2013 09:13:23 -0400 [thread overview]
Message-ID: <20130618091323.26c2988b@redhat.com> (raw)
In-Reply-To: <51C02766.5020301@redhat.com>
On Tue, 18 Jun 2013 11:24:54 +0200
Gerd Hoffmann <kraxel@redhat.com> wrote:
> On 06/17/13 16:50, Luiz Capitulino wrote:
> >>> > > +struct screendump_job {
> >>> > > + QEMUBH *bh;
> >>> > > + QemuConsole *con;
> >>> > > + char *filename;
> >>> > > +};
> >> >
> >> > We have a job API in the block layer. Would it make sense to have a
> >> > QMP-level job interface?
> > I'd agree with this.
>
> Something like the attached patch? Which is just the bare minimum I'll
> need for screendump. Basically a one-off bottom half with some monitor
> infrastructure (job id, error handling). So it isn't for big jobs, but
> for small jobs which have to wait for something before they execute
> (spice-server, guest action, whatever).
I only skimmed over the patch, but you need QMP commands to cancel
and to query running jobs. Also, please move all this stuff to qmp.c
and do s/monitor/qmp rename.
Lastly, is it possible to have the block job QMP API on top of this
new QMP job API?
next prev parent reply other threads:[~2013-06-18 13:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 14:01 [Qemu-devel] [RfC PATCH 0/2] new screendump qmp command Gerd Hoffmann
2013-06-17 14:01 ` [Qemu-devel] [RfC PATCH 1/2] display update with notification Gerd Hoffmann
2013-06-17 14:39 ` Anthony Liguori
2013-06-17 14:01 ` [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd Gerd Hoffmann
2013-06-17 14:43 ` Anthony Liguori
2013-06-17 14:50 ` Luiz Capitulino
2013-06-18 9:24 ` Gerd Hoffmann
2013-06-18 13:13 ` Luiz Capitulino [this message]
2013-06-18 13:24 ` Gerd Hoffmann
2013-06-18 14:47 ` Stefan Hajnoczi
2013-06-25 10:28 ` Gerd Hoffmann
2013-07-12 17:01 ` Eric Blake
2013-07-12 17:06 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130618091323.26c2988b@redhat.com \
--to=lcapitulino@redhat.com \
--cc=alevy@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).