From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47271)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Uovj0-00007I-TC
	for qemu-devel@nongnu.org; Tue, 18 Jun 2013 09:13:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Uoviv-0006JN-WA
	for qemu-devel@nongnu.org; Tue, 18 Jun 2013 09:13:30 -0400
Received: from mx1.redhat.com ([209.132.183.28]:6862)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Uoviv-0006JG-Ou
	for qemu-devel@nongnu.org; Tue, 18 Jun 2013 09:13:25 -0400
Date: Tue, 18 Jun 2013 09:13:23 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20130618091323.26c2988b@redhat.com>
In-Reply-To: <51C02766.5020301@redhat.com>
References: <1371477707-7039-1-git-send-email-kraxel@redhat.com>
	<1371477707-7039-3-git-send-email-kraxel@redhat.com>
	<87a9mo4x38.fsf@codemonkey.ws> <20130617105018.26c2eadc@redhat.com>
	<51C02766.5020301@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp
 cmd
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, alevy@redhat.com, stefanha@redhat.com

On Tue, 18 Jun 2013 11:24:54 +0200
Gerd Hoffmann <kraxel@redhat.com> wrote:

> On 06/17/13 16:50, Luiz Capitulino wrote:
> >>> > > +struct screendump_job {
> >>> > > +    QEMUBH *bh;
> >>> > > +    QemuConsole *con;
> >>> > > +    char *filename;
> >>> > > +};
> >> > 
> >> > We have a job API in the block layer.  Would it make sense to have a
> >> > QMP-level job interface?
> > I'd agree with this.
> 
> Something like the attached patch?  Which is just the bare minimum I'll
> need for screendump.  Basically a one-off bottom half with some monitor
> infrastructure (job id, error handling).  So it isn't for big jobs, but
> for small jobs which have to wait for something before they execute
> (spice-server, guest action, whatever).

I only skimmed over the patch, but you need QMP commands to cancel
and to query running jobs. Also, please move all this stuff to qmp.c
and do s/monitor/qmp rename.

Lastly, is it possible to have the block job QMP API on top of this
new QMP job API?