From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41687)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UovJS-00084h-Vz
	for qemu-devel@nongnu.org; Tue, 18 Jun 2013 08:47:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UovJR-00066f-N7
	for qemu-devel@nongnu.org; Tue, 18 Jun 2013 08:47:06 -0400
Received: from mail-we0-x229.google.com ([2a00:1450:400c:c03::229]:54963)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UovJR-00066a-H1
	for qemu-devel@nongnu.org; Tue, 18 Jun 2013 08:47:05 -0400
Received: by mail-we0-f169.google.com with SMTP id n57so3391123wev.28
	for <qemu-devel@nongnu.org>; Tue, 18 Jun 2013 05:47:04 -0700 (PDT)
Date: Tue, 18 Jun 2013 14:47:02 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130618124702.GK7649@stefanha-thinkpad.redhat.com>
References: <1371114186-8854-1-git-send-email-qemulist@gmail.com>
	<1371114186-8854-5-git-send-email-qemulist@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1371114186-8854-5-git-send-email-qemulist@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2 4/6] net: force NetQue opaque to be
 NetClientState
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Liu Ping Fan <qemulist@gmail.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, mdroth <mdroth@linux.vnet.ibm.com>

On Thu, Jun 13, 2013 at 05:03:04PM +0800, Liu Ping Fan wrote:
> From: Liu Ping Fan <pingfanl@linux.vnet.ibm.com>
> 
> qemu_net_client_setup() is the only user of qemu_new_net_queue(), which
> will pass in NetClientState. By forcing it be a NetClientState, we
> can ref/unref NetQueue's owner

Please s/opaque/nc/ in net/queue.[hc] since it's no longer "opaque" :).

Also, qemu_deliver_packet()/qemu_deliver_packet_iov() can take an
NetClientState *nc instead of void *opaque.

> Signed-off-by: Liu Ping Fan <pingfank@linux.vnet.ibm.com>

pingfank here and pingfanl in the From: header.  Are both okay and which
do you prefer to use?