From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42362)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1UovNV-0005tb-Dx
	for qemu-devel@nongnu.org; Tue, 18 Jun 2013 08:51:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1UovNR-0007Bx-BL
	for qemu-devel@nongnu.org; Tue, 18 Jun 2013 08:51:17 -0400
Received: from mx1.redhat.com ([209.132.183.28]:35202)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1UovNR-0007Br-3i
	for qemu-devel@nongnu.org; Tue, 18 Jun 2013 08:51:13 -0400
Date: Tue, 18 Jun 2013 15:51:58 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20130618125158.GA23792@redhat.com>
References: <1371554221-5762-1-git-send-email-paul.durrant@citrix.com>
	<51C054A6.70308@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <51C054A6.70308@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/2] Remove hardcoded xen-platform device
 initialization (v4)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laszlo Ersek <lersek@redhat.com>
Cc: Paul Durrant <paul.durrant@citrix.com>, qemu-devel@nongnu.org

On Tue, Jun 18, 2013 at 02:37:58PM +0200, Laszlo Ersek wrote:
> Hi Paul,
> 
> (xen-devel snipped)
> 
> On 06/18/13 13:16, Paul Durrant wrote:
> > Because of concerns over backwards compatibility and a suggestion that
> > xenfv should be retired in favour of using the pc machine type I have re-
> > worked my original patch into 2 patches:
> > 
> > [PATCH 1/2] Allow use of pc machine type (accel=xen) for Xen HVM
> > [PATCH 2/2] Move hardcoded initialization of xen-platform device.
> > 
> > Application of both these patches allows alternative pc machine types to be
> > used with the accel=xen option, but preserves the hardcoded creation of
> > the xen-platform device only for machine type xenfv.
> > 
> > v3:
> > - Add test for xen_enabled() that went missing in v2
> > 
> > v4:
> > - Remove erroneous whitespace hunk
> > - Replace hw_error() with fprintf()+exit(1)
> > - Add braces to single-line if
> 
> can you please offer an opinion in the
> 
>   [PATCH 1/2] pvpanic: initialization cleanup
>   http://thread.gmane.org/gmane.comp.emulators.qemu/216940
> 
> thread?
> 
> >From where I stand (which is "quite afar" :)) this series of yours seems
> somewhat related to my doubt there.
> 
> Thanks!
> Laszlo

OK will make it skip fwcfg as we did earlier.
Thanks for the review.

-- 
MST