From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53637)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1UpGK9-0001af-N7
	for qemu-devel@nongnu.org; Wed, 19 Jun 2013 07:13:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1UpGK8-0000GK-1A
	for qemu-devel@nongnu.org; Wed, 19 Jun 2013 07:13:13 -0400
Received: from mx1.redhat.com ([209.132.183.28]:63777)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1UpGK7-0000Er-PZ
	for qemu-devel@nongnu.org; Wed, 19 Jun 2013 07:13:11 -0400
Date: Wed, 19 Jun 2013 13:13:06 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20130619111306.GG2934@dhcp-200-207.str.redhat.com>
References: <1369917299-5725-1-git-send-email-stefanha@redhat.com>
	<1369917299-5725-8-git-send-email-stefanha@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1369917299-5725-8-git-send-email-stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 07/11] blockdev: rename
 BlkTransactionStates to singular
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org, dietmar@proxmox.com, imain@redhat.com, Paolo Bonzini <pbonzini@redhat.com>, xiawenc@linux.vnet.ibm.com

Am 30.05.2013 um 14:34 hat Stefan Hajnoczi geschrieben:
> The QMP 'transaction' command keeps a list of in-flight transactions.
> The transaction state structure is called BlkTransactionStates even
> though it only deals with a single transaction.  The only plural thing
> is the linked list of transaction states.
> 
> I find it confusing to call the single structure "States".  This patch
> renames it to "State", just like BlockDriverState is singular.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

> -    /* This removes our old bs from the bdrv_states, and adds the new bs */
> -    bdrv_append(states->new_bs, states->old_bs);
> +    /* This removes our old bs and adds the new bs */
> +    bdrv_append(state->new_bs, state->old_bs);

Tsk, you said this was only renaming. Don't believe I didn't see it!

Reviewed-by: Kevin Wolf <kwolf@redhat.com>