From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53886) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpGLW-0002lf-PL for qemu-devel@nongnu.org; Wed, 19 Jun 2013 07:14:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UpGLV-0000eD-WE for qemu-devel@nongnu.org; Wed, 19 Jun 2013 07:14:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62714) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpGLV-0000e2-PB for qemu-devel@nongnu.org; Wed, 19 Jun 2013 07:14:37 -0400 Date: Wed, 19 Jun 2013 13:14:32 +0200 From: Kevin Wolf Message-ID: <20130619111432.GH2934@dhcp-200-207.str.redhat.com> References: <1369917299-5725-1-git-send-email-stefanha@redhat.com> <1369917299-5725-9-git-send-email-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1369917299-5725-9-git-send-email-stefanha@redhat.com> Subject: Re: [Qemu-devel] [PATCH v5 08/11] blockdev: allow BdrvActionOps->commit() to be NULL List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Fam Zheng , qemu-devel@nongnu.org, dietmar@proxmox.com, imain@redhat.com, Paolo Bonzini , xiawenc@linux.vnet.ibm.com Am 30.05.2013 um 14:34 hat Stefan Hajnoczi geschrieben: > Some QMP 'transaction' types don't need to do anything on .commit(). > Make .commit() optional just like .abort(). > > The "drive-backup" action will take advantage of this, it only needs to > cancel the block job on .abort(). Other block job actions will probably > follow the same pattern, so allow .commit() to be NULL. > > Suggested-by: Eric Blake > Signed-off-by: Stefan Hajnoczi Reviewed-by: Kevin Wolf