From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55524) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpGSr-0008Mo-3H for qemu-devel@nongnu.org; Wed, 19 Jun 2013 07:22:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UpGSq-00039D-1V for qemu-devel@nongnu.org; Wed, 19 Jun 2013 07:22:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1234) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpGSp-000399-QH for qemu-devel@nongnu.org; Wed, 19 Jun 2013 07:22:11 -0400 Date: Wed, 19 Jun 2013 13:21:42 +0200 From: Kevin Wolf Message-ID: <20130619112142.GJ2934@dhcp-200-207.str.redhat.com> References: <1369917299-5725-1-git-send-email-stefanha@redhat.com> <1369917299-5725-11-git-send-email-stefanha@redhat.com> <51A74FFD.1020207@redhat.com> <20130603092130.GD16498@stefanha-thinkpad.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130603092130.GD16498@stefanha-thinkpad.redhat.com> Subject: Re: [Qemu-devel] [PATCH v5 10/11] blockdev: add Abort transaction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Fam Zheng , qemu-devel@nongnu.org, xiawenc@linux.vnet.ibm.com, imain@redhat.com, Paolo Bonzini , dietmar@proxmox.com Am 03.06.2013 um 11:21 hat Stefan Hajnoczi geschrieben: > On Thu, May 30, 2013 at 07:11:25AM -0600, Eric Blake wrote: > > On 05/30/2013 06:34 AM, Stefan Hajnoczi wrote: > > > The Abort action can be used to test QMP 'transaction' failure. Add it > > > as the last action to exercise the .abort() and .cleanup() code paths > > > for all previous actions. > > > > Another thread questioned whether we should name this action > > __org.qemu-debug-abort, if only to be clear that it is not a normal > > interface. > > kwolf: Do you want Abort to be namespaced as a debug-only action? > > I think it's perfectly supportable so there's no need to hide it. > Granted it's rare that anyone would want to use this action. I don't have a strong opinion on this. On the one hand it's probably useless outside testing and debugging, on the other hand it won't be a pain to support and the interface looks like it could be stable for the next few years... It's your patch, so you get to decide. Reviewed-by: Kevin Wolf