From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43623)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1UpJ7X-0004r8-AN
	for qemu-devel@nongnu.org; Wed, 19 Jun 2013 10:12:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1UpJ7U-0001IY-KH
	for qemu-devel@nongnu.org; Wed, 19 Jun 2013 10:12:23 -0400
Received: from mx1.redhat.com ([209.132.183.28]:22762)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1UpJ7U-0001IP-DT
	for qemu-devel@nongnu.org; Wed, 19 Jun 2013 10:12:20 -0400
Date: Wed, 19 Jun 2013 17:13:03 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20130619141303.GA5927@redhat.com>
References: <1371560351-29057-1-git-send-email-mst@redhat.com>
	<51C1BB1F.3000305@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <51C1BB1F.3000305@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/2] pvpanic: initialization cleanup
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laszlo Ersek <lersek@redhat.com>
Cc: Hu Tao <hutao@cn.fujitsu.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>

On Wed, Jun 19, 2013 at 04:07:27PM +0200, Laszlo Ersek wrote:
> On 06/18/13 15:01, Michael S. Tsirkin wrote:
> > Avoid use of static variables: PC systems
> > initialize pvpanic device through pvpanic_init,
> > so we can simply create the fw_cfg file at that point.
> > This also makes it possible to assert if fw_cfg is not there
> > rather than skipping the device silently.
> > 
> > Reviewed-by:  Laszlo Ersek <lersek@redhat.com>
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > 
> > Changes from v1:
> >     don't assert if !fw_cfg, simply skip fwcfg
> > 
> >  hw/misc/pvpanic.c | 26 ++++++++++++++------------
> >  1 file changed, 14 insertions(+), 12 deletions(-)
> 
> Patches look good, however I think you missed to update the 1/2 commit
> message completely. You removed the sentence
> 
>   Others don't use fw_cfg at all.
> 
> but
> 
>   This also makes it possible to assert if fw_cfg is not there rather
>   than skipping the device silently.
> 
> remains, although it's exactly the assert() that's been erased.
> 
> Laszlo

Good point. It's going in through my tree so I'll tweak the
commit log but won't repost.
Thanks a lot for the thorough review!