From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44232)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UpJBU-0001H7-CE
	for qemu-devel@nongnu.org; Wed, 19 Jun 2013 10:16:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UpJBT-0002KV-2x
	for qemu-devel@nongnu.org; Wed, 19 Jun 2013 10:16:28 -0400
Received: from mail-wg0-x22d.google.com ([2a00:1450:400c:c00::22d]:64475)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UpJBS-0002KM-U2
	for qemu-devel@nongnu.org; Wed, 19 Jun 2013 10:16:27 -0400
Received: by mail-wg0-f45.google.com with SMTP id j13so4682046wgh.24
	for <qemu-devel@nongnu.org>; Wed, 19 Jun 2013 07:16:26 -0700 (PDT)
Date: Wed, 19 Jun 2013 16:16:22 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130619141622.GF31475@stefanha-thinkpad.muc.redhat.com>
References: <1371576844-28743-1-git-send-email-mjt@msgid.tls.msk.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1371576844-28743-1-git-send-email-mjt@msgid.tls.msk.ru>
Subject: Re: [Qemu-devel] [RFC PATCH 0/4] per-object libraries
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-devel@nongnu.org

On Tue, Jun 18, 2013 at 09:34:00PM +0400, Michael Tokarev wrote:
> The foo.cflags isn't really necessary, but when you specify one
> thing one way (target-specific variable), and another thing completely
> different way, resulting code does not look nice.  In particular, the
> two curl definitions in block/Makefile.objs look somewhat funky if
> curl.cflags isn't used.

Specifying per-object file or per-module LIBS/CFLAGS is great.  I wonder
if we can do it like kbuild though:
CFLAGS_i915_trace_points.o := -I$(src)

It only takes the object file name, not the path.  Could be a problem if
we have files with the same name in different directories I guess.

But I wonder if this approach would let you drop the $(obj)filename.o
change.  I didn't review closely enough to really understand how that
works though :-).

Stefan