From: Stefan Hajnoczi <stefanha@redhat.com>
To: liu ping fan <qemulist@gmail.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
qemu-devel@nongnu.org, mdroth <mdroth@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v2 2/6] net: introduce lock to protect NetClientState's peer's access
Date: Thu, 20 Jun 2013 09:46:03 +0200 [thread overview]
Message-ID: <20130620074603.GC15082@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <CAJnKYQkg_sfXEHc5Y12=d_wxuu3dP3L6vT5sHQ5t+j-xzs8X-Q@mail.gmail.com>
On Thu, Jun 20, 2013 at 02:30:30PM +0800, liu ping fan wrote:
> On Tue, Jun 18, 2013 at 8:25 PM, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> > On Thu, Jun 13, 2013 at 05:03:02PM +0800, Liu Ping Fan wrote:
> >> + * And flush out peer's queue.
> >> + */
> >> +static void qemu_net_client_detach_flush(NetClientState *nc)
> >> +{
> >> + NetClientState *peer;
> >> +
> >> + /* reader of self's peer field , fixme? the deleters are not concurrent,
> >> + * so this pair lock can save.
> >> + */
> >
> > Indentation, also please resolve the fixme.
> >
> So, here can I take the assumption that the deleters are serialized by
> biglock, and remove the lock following this comment?
Ah, I understand the comment now. Is there any advantage to dropping
the lock? IMO it's clearer to take the lock consistently instead of
"optimizing" cases we think only get called from the main loop.
next prev parent reply other threads:[~2013-06-20 7:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-13 9:03 [Qemu-devel] [PATCH v2 0/6] port network layer onto glib Liu Ping Fan
2013-06-13 9:03 ` [Qemu-devel] [PATCH v2 1/6] net: introduce lock to protect NetQueue Liu Ping Fan
2013-06-13 9:03 ` [Qemu-devel] [PATCH v2 2/6] net: introduce lock to protect NetClientState's peer's access Liu Ping Fan
2013-06-18 12:25 ` Stefan Hajnoczi
2013-06-20 6:30 ` liu ping fan
2013-06-20 7:46 ` Stefan Hajnoczi [this message]
2013-06-20 9:17 ` liu ping fan
2013-06-13 9:03 ` [Qemu-devel] [PATCH v2 3/6] net: make netclient re-entrant with refcnt Liu Ping Fan
2013-06-18 12:41 ` Stefan Hajnoczi
2013-06-20 9:14 ` liu ping fan
2013-07-01 11:50 ` Stefan Hajnoczi
2013-07-03 3:41 ` liu ping fan
2013-07-03 7:49 ` Stefan Hajnoczi
2013-07-03 7:54 ` liu ping fan
2013-07-03 12:01 ` Stefan Hajnoczi
2013-06-13 9:03 ` [Qemu-devel] [PATCH v2 4/6] net: force NetQue opaque to be NetClientState Liu Ping Fan
2013-06-18 12:47 ` Stefan Hajnoczi
2013-06-20 6:30 ` liu ping fan
2013-06-13 9:03 ` [Qemu-devel] [PATCH v2 5/6] net: defer nested call to BH Liu Ping Fan
2013-06-18 12:57 ` Stefan Hajnoczi
2013-06-20 6:30 ` liu ping fan
2013-06-20 7:48 ` Stefan Hajnoczi
2013-07-03 6:20 ` Paolo Bonzini
2013-06-13 9:03 ` [Qemu-devel] [PATCH v2 6/6] net: hub use lock to protect ports list Liu Ping Fan
2013-06-18 13:07 ` [Qemu-devel] [PATCH v2 0/6] port network layer onto glib Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130620074603.GC15082@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemulist@gmail.com \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).