From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52729) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Updpe-0006YY-Iq for qemu-devel@nongnu.org; Thu, 20 Jun 2013 08:19:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UpdpU-0007g7-7G for qemu-devel@nongnu.org; Thu, 20 Jun 2013 08:19:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17276) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpdpT-0007fs-UQ for qemu-devel@nongnu.org; Thu, 20 Jun 2013 08:19:08 -0400 Date: Thu, 20 Jun 2013 14:19:03 +0200 From: Stefan Hajnoczi Message-ID: <20130620121903.GE16926@stefanha-thinkpad.redhat.com> References: <1369917299-5725-1-git-send-email-stefanha@redhat.com> <1369917299-5725-7-git-send-email-stefanha@redhat.com> <20130619110741.GF2934@dhcp-200-207.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130619110741.GF2934@dhcp-200-207.str.redhat.com> Subject: Re: [Qemu-devel] [PATCH v5 06/11] block: add drive-backup QMP command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Fam Zheng , qemu-devel@nongnu.org, dietmar@proxmox.com, imain@redhat.com, Paolo Bonzini , xiawenc@linux.vnet.ibm.com On Wed, Jun 19, 2013 at 01:07:42PM +0200, Kevin Wolf wrote: > Am 30.05.2013 um 14:34 hat Stefan Hajnoczi geschrieben: > > @drive-backup > > > > Start a point-in-time copy of a block device to a new destination. The > > status of ongoing drive-backup operations can be checked with > > query-block-jobs where the BlockJobInfo.type field has the value 'backup'. > > The operation can be stopped before it has completed using the > > block-job-cancel command. > > > > @device: the name of the device which should be copied. > > > > @target: the target of the new image. If the file exists, or if it > > is a device, the existing file/device will be used as the new > > destination. If it does not exist, a new file will be created. > > > > @format: #optional the format of the new destination, default is to > > probe if @mode is 'existing', else the format of the source > > > > @mode: #optional whether and how QEMU should create a new image, default is > > 'absolute-paths'. > > > > @speed: #optional the maximum speed, in bytes per second > > > > @on-source-error: #optional the action to take on an error on the source, > > default 'report'. 'stop' and 'enospc' can only be used > > if the block device supports io-status (see BlockInfo). > > > > @on-target-error: #optional the action to take on an error on the target, > > default 'report' (no limitations, since this applies to > > a different block device than @device). > > > > Note that @on-source-error and @on-target-error only affect background I/O. > > If an error occurs during a guest write request, the device's rerror/werror > > actions will be used. > > > > Returns: nothing on success > > If @device is not a valid block device, DeviceNotFound > > > > Since 1.6 > > > > Signed-off-by: Stefan Hajnoczi > > Reviewed-by: Kevin Wolf > > But what about HMP, the series doesn't seem to have a separate patch to > add a command there? I can send it as a follow-up if you want. The test cases use QMP and so do management tools - I didn't feel the need for HMP. Stefan