From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35174)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Uq2yr-0008NO-5b
	for qemu-devel@nongnu.org; Fri, 21 Jun 2013 11:10:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Uq2yq-0000Hl-20
	for qemu-devel@nongnu.org; Fri, 21 Jun 2013 11:10:29 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59254)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Uq2yp-0000Hg-Q9
	for qemu-devel@nongnu.org; Fri, 21 Jun 2013 11:10:27 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5LFAQwn007086
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 21 Jun 2013 11:10:27 -0400
Date: Fri, 21 Jun 2013 11:10:13 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20130621111013.5668e26d@redhat.com>
In-Reply-To: <51C42B80.7030206@redhat.com>
References: <1371659287-14331-1-git-send-email-kwolf@redhat.com>
	<1371659287-14331-4-git-send-email-kwolf@redhat.com>
	<51C42B80.7030206@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/3] qapi-schema: Use BlockdevSnapshot type
 for blockdev-snapshot-sync
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, stefanha@redhat.com, armbru@redhat.com

On Fri, 21 Jun 2013 11:31:28 +0100
Eric Blake <eblake@redhat.com> wrote:

> On 06/19/2013 05:28 PM, Kevin Wolf wrote:
> > We don't have to duplicate the definition any more now that we may refer
> > to a type instead.
> > 
> > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> > ---
> >  qapi-schema.json | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/qapi-schema.json b/qapi-schema.json
> > index a80ee40..ee19d6a 100644
> > --- a/qapi-schema.json
> > +++ b/qapi-schema.json
> > @@ -1669,8 +1669,7 @@
> >  # Since 0.14.0
> >  ##
> >  { 'command': 'blockdev-snapshot-sync',
> > -  'data': { 'device': 'str', 'snapshot-file': 'str', '*format': 'str',
> > -            '*mode': 'NewImageMode'} }
> > +  'data': 'BlockdevSnapshot' }
> 
> There's still duplication of the doc comments, but as we don't have
> anything parsing doc comments to convert them into a more usable form
> yet, that can be something we worry about later.

Let's document it now.

Series looks good otherwise.