From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37605) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ur084-0008Q9-KB for qemu-devel@nongnu.org; Mon, 24 Jun 2013 02:19:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ur081-0000px-0E for qemu-devel@nongnu.org; Mon, 24 Jun 2013 02:19:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56467) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ur080-0000pl-Oa for qemu-devel@nongnu.org; Mon, 24 Jun 2013 02:19:52 -0400 Date: Mon, 24 Jun 2013 14:19:56 +0800 From: Fam Zheng Message-ID: <20130624061956.GA13610@t430s.nay.redhat.com> References: <1371093689-18228-1-git-send-email-famz@redhat.com> <20130613083808.GE2633@stefanha-thinkpad.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130613083808.GE2633@stefanha-thinkpad.redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] vmdk: refuse to open higher version than supported Reply-To: famz@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , kwolf@redhat.com Cc: qemu-devel@nongnu.org, stefanha@redhat.com On Thu, 06/13 10:38, Stefan Hajnoczi wrote: > On Thu, Jun 13, 2013 at 11:21:29AM +0800, Fam Zheng wrote: > > Refuse to open higher version for safety. > > > > Although we try to be compatible with published VMDK spec, VMware has > > newer version from ESXi 5.1 exported OVF/OVA, which we have no knowledge > > what's changed in it. And it is very likely to have more new versions in > > the future, so it's not safe to open them blindly. > > > > Signed-off-by: Fam Zheng > > > > --- > > > > v2: Report error and return -ENOTSUP. > > > > --- > > block/vmdk.c | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > Reviewed-by: Stefan Hajnoczi Is this OK to be applied? Thanks. -- Fam