From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42826) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ur5mX-00021J-4B for qemu-devel@nongnu.org; Mon, 24 Jun 2013 08:22:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ur5mV-0007zN-R6 for qemu-devel@nongnu.org; Mon, 24 Jun 2013 08:22:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53916) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ur5mV-0007zC-K2 for qemu-devel@nongnu.org; Mon, 24 Jun 2013 08:22:03 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5OCM3hj012619 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 24 Jun 2013 08:22:03 -0400 Date: Mon, 24 Jun 2013 14:22:01 +0200 From: Kevin Wolf Message-ID: <20130624122201.GD3338@dhcp-200-207.str.redhat.com> References: <1371831528-1128-1-git-send-email-fsimonce@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1371831528-1128-1-git-send-email-fsimonce@redhat.com> Subject: Re: [Qemu-devel] [PATCH] block: add apparent-size to query-block List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Federico Simoncelli Cc: qemu-devel@nongnu.org Am 21.06.2013 um 18:18 hat Federico Simoncelli geschrieben: > This patch adds the apparent-size entry to the query-block output. > The value represents the apparent size in bytes of the image, e.g. > file size (including the blocks not yet allocated) or block device > size. > > Signed-off-by: Federico Simoncelli Instead of pulling one specific field up from bs->file and giving it a non-obvious name, we should rather add something generally useful like a field '*file': 'ImageInfo' that works as an analog to *backing-image, just that it contains the info for bs->file instead of bs->backing_hd. Kevin