From: Kevin Wolf <kwolf@redhat.com>
To: Liu Ping Fan <qemulist@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCH v5] QEMUBH: make AioContext's bh re-entrant
Date: Tue, 25 Jun 2013 11:40:21 +0200 [thread overview]
Message-ID: <20130625094021.GA3539@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <1372181185-3595-1-git-send-email-pingfank@linux.vnet.ibm.com>
Am 25.06.2013 um 19:26 hat Liu Ping Fan geschrieben:
> BH will be used outside big lock, so introduce lock to protect
> between the writers, ie, bh's adders and deleter. The lock only
> affects the writers and bh's callback does not take this extra lock.
> Note that for the same AioContext, aio_bh_poll() can not run in
> parallel yet.
>
> Signed-off-by: Liu Ping Fan <pingfank@linux.vnet.ibm.com>
>
> ---------
Please use exactly three dashes so that 'git am' recognises it as the
end of the commit message.
This doesn't compile yet because smp_read_barrier_depends() isn't merged
yet, so maybe there's still time for some nitpicking: Wouldn't using
atomic_set/get better document things and make them easier to read?
It should be correct anyway, so:
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
next prev parent reply other threads:[~2013-06-25 9:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-25 17:26 [Qemu-devel] [PATCH v5] QEMUBH: make AioContext's bh re-entrant Liu Ping Fan
2013-06-25 8:45 ` Stefan Hajnoczi
2013-06-25 9:40 ` Kevin Wolf [this message]
2013-06-25 10:09 ` Paolo Bonzini
2013-06-26 9:46 ` liu ping fan
2013-07-05 13:46 ` Stefan Hajnoczi
2013-07-05 14:12 ` Paolo Bonzini
-- strict thread matches above, loose matches on Subject: below --
2013-07-07 10:00 Liu Ping Fan
2013-07-07 12:31 ` Andreas Färber
2013-07-08 1:58 ` liu ping fan
2013-07-15 9:28 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130625094021.GA3539@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemulist@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).