From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34828) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrPjh-0002lj-LH for qemu-devel@nongnu.org; Tue, 25 Jun 2013 05:40:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UrPjf-0007Uc-BW for qemu-devel@nongnu.org; Tue, 25 Jun 2013 05:40:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8602) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrPjf-0007UH-3W for qemu-devel@nongnu.org; Tue, 25 Jun 2013 05:40:27 -0400 Date: Tue, 25 Jun 2013 11:40:21 +0200 From: Kevin Wolf Message-ID: <20130625094021.GA3539@dhcp-200-207.str.redhat.com> References: <1372181185-3595-1-git-send-email-pingfank@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1372181185-3595-1-git-send-email-pingfank@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v5] QEMUBH: make AioContext's bh re-entrant List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liu Ping Fan Cc: Paolo Bonzini , Stefan Hajnoczi , qemu-devel@nongnu.org, Anthony Liguori Am 25.06.2013 um 19:26 hat Liu Ping Fan geschrieben: > BH will be used outside big lock, so introduce lock to protect > between the writers, ie, bh's adders and deleter. The lock only > affects the writers and bh's callback does not take this extra lock. > Note that for the same AioContext, aio_bh_poll() can not run in > parallel yet. > > Signed-off-by: Liu Ping Fan > > --------- Please use exactly three dashes so that 'git am' recognises it as the end of the commit message. This doesn't compile yet because smp_read_barrier_depends() isn't merged yet, so maybe there's still time for some nitpicking: Wouldn't using atomic_set/get better document things and make them easier to read? It should be correct anyway, so: Reviewed-by: Kevin Wolf