From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37590)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UrqAG-00065B-9U
	for qemu-devel@nongnu.org; Wed, 26 Jun 2013 09:53:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UrqAE-0007YX-9o
	for qemu-devel@nongnu.org; Wed, 26 Jun 2013 09:53:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:21443)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UrqAD-0007Y1-Oo
	for qemu-devel@nongnu.org; Wed, 26 Jun 2013 09:53:37 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5QDraj7028995
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 26 Jun 2013 09:53:36 -0400
Date: Wed, 26 Jun 2013 09:53:35 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20130626095335.76dcd315@redhat.com>
In-Reply-To: <87d2r9l5u1.fsf@blackfin.pond.sub.org>
References: <1369300080-31377-1-git-send-email-akong@redhat.com>
	<1369300080-31377-2-git-send-email-akong@redhat.com>
	<519E0530.1090101@redhat.com>
	<87d2r9l5u1.fsf@blackfin.pond.sub.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 1/2] net: introduce RX_FILTER_CHANGED
 event
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Amos Kong <akong@redhat.com>, qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com

On Wed, 26 Jun 2013 08:54:46 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> Eric Blake <eblake@redhat.com> writes:
> 
> > On 05/23/2013 03:07 AM, Amos Kong wrote:
> >> Introduce this new QMP event to notify management after guest changes
> >> rx-filter configuration.
> >> 
> >> Signed-off-by: Amos Kong <akong@redhat.com>
> >> ---
> >>  QMP/qmp-events.txt        | 14 ++++++++++++++
> >>  include/monitor/monitor.h |  1 +
> >>  monitor.c                 |  1 +
> >>  3 files changed, 16 insertions(+)
> >> 
> >> diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt
> >> index 92fe5fb..ad6612b 100644
> >> --- a/QMP/qmp-events.txt
> >> +++ b/QMP/qmp-events.txt
> >> @@ -154,6 +154,20 @@ Data:
> >>              "path": "/machine/peripheral/virtio-net-pci-0" },
> >>    "timestamp": { "seconds": 1265044230, "microseconds": 450486 } }
> >>  
> >> +RX_FILTER_CHANGED
> >> +-----------------
> >
> >> +
> >>  DEVICE_TRAY_MOVED
> >>  -----------------
> >
> > Isn't this file supposed to be kept in sorted order, to minimize merge
> > conflicts when backporting events?
> 
> Yes, please.  Also helps humans navigate.
> 
> GUEST_PANICKED is out of order, needs fixing.

The ultimate fix would be to add event support to the qapi.