From: Kevin Wolf <kwolf@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Fam Zheng <famz@redhat.com>,
qemu-devel@nongnu.org, stefanha@redhat.com,
qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] vmdk: remove wrong calculation of relative path
Date: Thu, 27 Jun 2013 09:55:35 +0200 [thread overview]
Message-ID: <20130627075535.GA2822@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <51CBE544.8070306@redhat.com>
Am 27.06.2013 um 09:09 hat Paolo Bonzini geschrieben:
> Il 26/06/2013 17:05, Kevin Wolf ha scritto:
> > Am 26.06.2013 um 11:24 hat Fam Zheng geschrieben:
> >> > When creating image with backing file, the driver tries to calculate the
> >> > relative path from created image file to backing file, but the path
> >> > computation is incorrect. e.g.:
> >> >
> >> > $ qemu-img create -f vmdk -b vmdk-data-disk.vmdk vmdk-data-snapshot1
> >> > Formatting 'vmdk-data-snapshot1', fmt=vmdk size=10737418240
> >> > backing_file='vmdk-data-disk.vmdk' compat6=off zeroed_grain=off
> >> >
> >> > $ qemu-img info vmdk-data-snapshot1
> >> > image: vmdk-data-snapshot1
> >> > file format: vmdk
> >> > virtual size: 10G (10737418240 bytes)
> >> > disk size: 12K
> >> > -> backing file: disk.vmdk
> >> >
> >> > The common part in file names, "vmdk-data-", is incorrectly forgotten by
> >> > relative_path(). As the VMDK specification has no restriction on
> >> > parentNameHint to be relative path, we simply remove this by using the
> >> > backing_file option.
> >> >
> >> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > Nice one. Thanks, applied to the block branch.
>
> Cc: qemu-stable@nongnu.org
Yeah, why not. I've added it to the commit message now.
Kevin
prev parent reply other threads:[~2013-06-27 7:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-26 9:24 [Qemu-devel] [PATCH] vmdk: remove wrong calculation of relative path Fam Zheng
2013-06-26 15:05 ` Kevin Wolf
2013-06-27 7:09 ` Paolo Bonzini
2013-06-27 7:55 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130627075535.GA2822@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).