qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel@nongnu.org, kwolf@redhat.com, imain@redhat.com,
	rjones@redhat.com, roliveri@redhat.com, obarenbo@redhat.com,
	pmyers@redhat.com, armbru@redhat.com, eblake@redhat.com,
	hbrock@redhat.com
Subject: Re: [Qemu-devel] [RFC PATCH 0/3] Point-in-time snapshot exporting with drive-backup
Date: Thu, 27 Jun 2013 10:17:50 +0200	[thread overview]
Message-ID: <20130627081750.GF13780@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <20130626073119.GB20711@t430s.nay.redhat.com>

On Wed, Jun 26, 2013 at 03:31:19PM +0800, Fam Zheng wrote:
> On Wed, 06/26 09:23, Paolo Bonzini wrote:
> > Il 26/06/2013 05:59, Fam Zheng ha scritto:
> > This leads to another observation: a sync:'none' block-backup job
> > probably should never complete, and should instead go on until explicit
> > cancellation.  This is because the job does no background writes, and
> > thus completion would only happen after the guest has written the whole
> > disk.  Writing the whole disk is rare enough that it will likely cause
> > bugs in the clients.  It is easier just to never complete the job.
> > 
> 
> Yes, the sync mode none will simply run forever until cancelled.

There is a dedicated command to successfully complete a job:

block-job-complete

Stefan

  reply	other threads:[~2013-06-27  8:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-26  3:59 [Qemu-devel] [RFC PATCH 0/3] Point-in-time snapshot exporting with drive-backup Fam Zheng
2013-06-26  3:59 ` [Qemu-devel] [RFC PATCH 1/3] block: add target-id option to drive-backup QMP command Fam Zheng
2013-06-27  8:15   ` Stefan Hajnoczi
2013-06-27  9:41     ` Fam Zheng
2013-06-27 10:57       ` Paolo Bonzini
2013-06-27 11:37         ` Fam Zheng
2013-06-27 11:40           ` Paolo Bonzini
2013-06-28  2:17             ` Fam Zheng
2013-06-26  3:59 ` [Qemu-devel] [RFC PATCH 2/3] block: assign backing relationship in drive-backup Fam Zheng
2013-06-26  7:15   ` Paolo Bonzini
2013-06-26  3:59 ` [Qemu-devel] [RFC PATCH 3/3] nbd: don't get ref if bs has no drive Fam Zheng
2013-06-26  7:23 ` [Qemu-devel] [RFC PATCH 0/3] Point-in-time snapshot exporting with drive-backup Paolo Bonzini
2013-06-26  7:31   ` Fam Zheng
2013-06-27  8:17     ` Stefan Hajnoczi [this message]
2013-06-27 10:06       ` Paolo Bonzini
2013-06-27 13:39         ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130627081750.GF13780@stefanha-thinkpad.redhat.com \
    --to=stefanha@redhat.com \
    --cc=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=hbrock@redhat.com \
    --cc=imain@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=obarenbo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=pmyers@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rjones@redhat.com \
    --cc=roliveri@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).