* [Qemu-devel] [PATCH] cmd646: fix build when DEBUG_IDE is enabled.
@ 2013-06-28 13:43 Mark Cave-Ayland
2013-06-28 13:52 ` Andreas Färber
2013-06-28 14:08 ` Kevin Wolf
0 siblings, 2 replies; 3+ messages in thread
From: Mark Cave-Ayland @ 2013-06-28 13:43 UTC (permalink / raw)
To: qemu-devel; +Cc: Kevin Wolf, Mark Cave-Ayland
Make sure we use the correct TARGET/PRI macros in the debug statements.
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
CC: Kevin Wolf <kwolf@redhat.com>
---
hw/ide/cmd646.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/ide/cmd646.c b/hw/ide/cmd646.c
index a73eb9a..9916701 100644
--- a/hw/ide/cmd646.c
+++ b/hw/ide/cmd646.c
@@ -154,7 +154,7 @@ static uint64_t bmdma_read(void *opaque, hwaddr addr,
break;
}
#ifdef DEBUG_IDE
- printf("bmdma: readb 0x%02x : 0x%02x\n", addr, val);
+ printf("bmdma: readb " TARGET_FMT_plx " : 0x%02x\n", addr, val);
#endif
return val;
}
@@ -170,7 +170,7 @@ static void bmdma_write(void *opaque, hwaddr addr,
}
#ifdef DEBUG_IDE
- printf("bmdma: writeb 0x%02x : 0x%02x\n", addr, val);
+ printf("bmdma: writeb " TARGET_FMT_plx " : 0x%" PRIx64 "\n", addr, val);
#endif
switch(addr & 3) {
case 0:
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] cmd646: fix build when DEBUG_IDE is enabled.
2013-06-28 13:43 [Qemu-devel] [PATCH] cmd646: fix build when DEBUG_IDE is enabled Mark Cave-Ayland
@ 2013-06-28 13:52 ` Andreas Färber
2013-06-28 14:08 ` Kevin Wolf
1 sibling, 0 replies; 3+ messages in thread
From: Andreas Färber @ 2013-06-28 13:52 UTC (permalink / raw)
To: Mark Cave-Ayland; +Cc: Kevin Wolf, qemu-devel
Am 28.06.2013 15:43, schrieb Mark Cave-Ayland:
> Make sure we use the correct TARGET/PRI macros in the debug statements.
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> CC: Kevin Wolf <kwolf@redhat.com>
> ---
> hw/ide/cmd646.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/ide/cmd646.c b/hw/ide/cmd646.c
> index a73eb9a..9916701 100644
> --- a/hw/ide/cmd646.c
> +++ b/hw/ide/cmd646.c
> @@ -154,7 +154,7 @@ static uint64_t bmdma_read(void *opaque, hwaddr addr,
> break;
> }
> #ifdef DEBUG_IDE
> - printf("bmdma: readb 0x%02x : 0x%02x\n", addr, val);
> + printf("bmdma: readb " TARGET_FMT_plx " : 0x%02x\n", addr, val);
To remain output-compatible you could use "0x%02" HWADDR_PRIx.
While touching it, "0x%02" PRIx32 would be consistent for uint32_t val.
Andreas
> #endif
> return val;
> }
> @@ -170,7 +170,7 @@ static void bmdma_write(void *opaque, hwaddr addr,
> }
>
> #ifdef DEBUG_IDE
> - printf("bmdma: writeb 0x%02x : 0x%02x\n", addr, val);
> + printf("bmdma: writeb " TARGET_FMT_plx " : 0x%" PRIx64 "\n", addr, val);
> #endif
> switch(addr & 3) {
> case 0:
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] cmd646: fix build when DEBUG_IDE is enabled.
2013-06-28 13:43 [Qemu-devel] [PATCH] cmd646: fix build when DEBUG_IDE is enabled Mark Cave-Ayland
2013-06-28 13:52 ` Andreas Färber
@ 2013-06-28 14:08 ` Kevin Wolf
1 sibling, 0 replies; 3+ messages in thread
From: Kevin Wolf @ 2013-06-28 14:08 UTC (permalink / raw)
To: Mark Cave-Ayland; +Cc: qemu-devel
Am 28.06.2013 um 15:43 hat Mark Cave-Ayland geschrieben:
> Make sure we use the correct TARGET/PRI macros in the debug statements.
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> CC: Kevin Wolf <kwolf@redhat.com>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-28 14:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-28 13:43 [Qemu-devel] [PATCH] cmd646: fix build when DEBUG_IDE is enabled Mark Cave-Ayland
2013-06-28 13:52 ` Andreas Färber
2013-06-28 14:08 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).