From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38493)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgibson@ozlabs.org>) id 1Usw93-0001Yu-KP
	for qemu-devel@nongnu.org; Sat, 29 Jun 2013 10:29:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dgibson@ozlabs.org>) id 1Usw8w-0006zt-Vj
	for qemu-devel@nongnu.org; Sat, 29 Jun 2013 10:28:57 -0400
Received: from ozlabs.org ([203.10.76.45]:40407)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgibson@ozlabs.org>) id 1Usw8w-0006yn-MB
	for qemu-devel@nongnu.org; Sat, 29 Jun 2013 10:28:50 -0400
Date: Sun, 30 Jun 2013 00:28:43 +1000
From: David Gibson <david@gibson.dropbear.id.au>
Message-ID: <20130629142843.GA16583@voom.fritz.box>
References: <1372513646-6053-1-git-send-email-sw@weilnetz.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="ZPt4rx8FFjLCG7dd"
Content-Disposition: inline
In-Reply-To: <1372513646-6053-1-git-send-email-sw@weilnetz.de>
Subject: Re: [Qemu-devel] [PATCH v2] spapr: Fix compiler warnings for some
	versions of gcc
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Alexander Graf <agraf@suse.de>, qemu-devel <qemu-devel@nongnu.org>


--ZPt4rx8FFjLCG7dd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Jun 29, 2013 at 03:47:26PM +0200, Stefan Weil wrote:
> i686-w64-mingw32-gcc (GCC) 4.6.3 from Debian wheezy reports these warning=
s:
>=20
> hw/ppc/spapr_hcall.c:188:1: warning:
>  control reaches end of non-void function [-Wreturn-type]
>=20
> hw/ppc/spapr_pci.c:454:1: warning:
>  control reaches end of non-void function [-Wreturn-type]
>=20
> Both warnings are fixed by using g_assert_not_reached instead of assert.
> A second line with assert(0) in spapr_pci.c which did not raise a compiler
> warning was modified, too, because g_assert_not_reached documents the
> purpose of that statement and is not removed in release builds.
>=20
> Signed-off-by: Stefan Weil <sw@weilnetz.de>

Makes sense to me.

Acked-by: David Gibson <david@gibson.dropbear.id.au>

--=20
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

--ZPt4rx8FFjLCG7dd
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (GNU/Linux)

iEYEARECAAYFAlHO7xsACgkQaILKxv3ab8anxgCdE7UeQn6qgmd/ZDStE4tQ6/Iz
ewMAnRCxtlML5QOjXyCkJYvC0E648VCO
=6n4j
-----END PGP SIGNATURE-----

--ZPt4rx8FFjLCG7dd--