From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36578) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UtUJz-0002UP-Hh for qemu-devel@nongnu.org; Sun, 30 Jun 2013 22:58:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UtUJx-00068f-NQ for qemu-devel@nongnu.org; Sun, 30 Jun 2013 22:58:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8472) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UtUJx-00068T-Eg for qemu-devel@nongnu.org; Sun, 30 Jun 2013 22:58:29 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r612wS4T005712 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 30 Jun 2013 22:58:28 -0400 Date: Mon, 1 Jul 2013 10:58:26 +0800 From: Amos Kong Message-ID: <20130701025826.GC1946@amosk.info> References: <1372055699-13501-1-git-send-email-akong@redhat.com> <87zjudi3zu.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zjudi3zu.fsf@blackfin.pond.sub.org> Subject: Re: [Qemu-devel] [PATCH for mst/pci] output nc->name in NIC_RX_FILTER_CHANGED event List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, mst@redhat.com On Wed, Jun 26, 2013 at 12:02:45PM +0200, Markus Armbruster wrote: > Amos Kong writes: > > > netclient 'name' entry in event is useful for management to know > > which device is changed. n->netclient_name is not always set. > > This patch changes to use nc->name. If we don't assign 'id', > > qemu will set a generated name to nc->name. > > > > Signed-off-by: Amos Kong > > --- > > hw/net/virtio-net.c | 11 +++-------- > > 1 file changed, 3 insertions(+), 8 deletions(-) > > > > diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c > > index c88403a..e4d9752 100644 > > --- a/hw/net/virtio-net.c > > +++ b/hw/net/virtio-net.c > > @@ -200,14 +200,9 @@ static void rxfilter_notify(NetClientState *nc) > > VirtIONet *n = qemu_get_nic_opaque(nc); > > > > if (nc->rxfilter_notify_enabled) { > > - if (n->netclient_name) { > > - event_data = qobject_from_jsonf("{ 'name': %s, 'path': %s }", > > - n->netclient_name, > > - object_get_canonical_path(OBJECT(n->qdev))); > > - } else { > > - event_data = qobject_from_jsonf("{ 'path': %s }", > > - object_get_canonical_path(OBJECT(n->qdev))); > > - } > > + event_data = qobject_from_jsonf("{ 'name': %s, 'path': %s }", > > + nc->name, > > + object_get_canonical_path(OBJECT(n->qdev))); > > monitor_protocol_event(QEVENT_NIC_RX_FILTER_CHANGED, event_data); > > qobject_decref(event_data); > > Is this on top of "[PATCH v3 0/2] mac programming over macvtap"? It's based on mst's pci tree: https://git.kernel.org/cgit/virt/kvm/mst/qemu.git/log/?h=pci https://git.kernel.org/cgit/virt/kvm/mst/qemu.git/commit/?h=pci&id=1c0fa6b709d02fe4f98d4ce7b55a6cc3c925791c > Yes, qdev IDs are optional, and therefore can serve as reliable > identifier only when the user / management application always specifies > one, and even then, you're still screwed for auto-created devices. > Easily avoided for NICs, but yes, the problem is real. > > However, I don't agree with the solution "use NetCientState name", > because that's too ad hoc, and not general. Can we please use QOM > paths? path is always provided in event, libvirt can use it. -- Amos.