From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46197) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UtUjD-0006Xm-2I for qemu-devel@nongnu.org; Sun, 30 Jun 2013 23:24:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UtUjB-0006mC-7P for qemu-devel@nongnu.org; Sun, 30 Jun 2013 23:24:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20998) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UtUjA-0006lk-SY for qemu-devel@nongnu.org; Sun, 30 Jun 2013 23:24:33 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r613OVGJ021175 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 30 Jun 2013 23:24:31 -0400 Date: Mon, 1 Jul 2013 11:24:26 +0800 From: Amos Kong Message-ID: <20130701032426.GF1946@amosk.info> References: <1369300080-31377-1-git-send-email-akong@redhat.com> <1369300080-31377-3-git-send-email-akong@redhat.com> <874ncljiyb.fsf@blackfin.pond.sub.org> <87fvw56q01.fsf@blackfin.pond.sub.org> <20130626100251.5ea9781e@redhat.com> <87txklez5z.fsf@blackfin.pond.sub.org> <51CD97FD.1000805@redhat.com> <87r4fm2lja.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87r4fm2lja.fsf@blackfin.pond.sub.org> Subject: Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: mst@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, Luiz Capitulino On Fri, Jun 28, 2013 at 07:27:21PM +0200, Markus Armbruster wrote: > Eric Blake writes: > > > On 06/26/2013 08:15 AM, Markus Armbruster wrote: > >> Luiz Capitulino writes: > >> > >>> On Wed, 26 Jun 2013 14:00:30 +0200 > >>> Markus Armbruster wrote: > >>> > >>>> Meh, I got confused and reviewed an out-of-date version. Hope it's not > >>>> entirely noise. > >>> > >>> I don't think it is. But this series got applied to Michael's tree, so > >>> if you want your comments addressed before applying to master (I think > >>> we do) then it's better to state it clearly. > >> > >> Michael, please give Amos a chance to reply to my review. > > > > Looks like the pull request is already live but had issues; meanwhile, I > > also found an issue when reviewing the pull request: > > https://lists.gnu.org/archive/html/qemu-devel/2013-06/msg05127.html > > Missed it, thanks! In mst's v2 pull, it still contains my patch, it's not merged to master by Anthony. I think mst should re-send a v3 without my patch as said in changelog. I will fix the problem in your reply, thanks. -- Amos.