From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59848)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1UteGG-000184-LU
	for qemu-devel@nongnu.org; Mon, 01 Jul 2013 09:35:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1UteG9-0005Vg-Ib
	for qemu-devel@nongnu.org; Mon, 01 Jul 2013 09:35:20 -0400
Received: from mx1.redhat.com ([209.132.183.28]:22513)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1UteG9-0005VV-9m
	for qemu-devel@nongnu.org; Mon, 01 Jul 2013 09:35:13 -0400
Date: Mon, 1 Jul 2013 15:35:03 +0200
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20130701133503.GB20182@stefanha-thinkpad.redhat.com>
References: <1372338695-411-1-git-send-email-pl@kamp.de>
	<1372338695-411-2-git-send-email-pl@kamp.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1372338695-411-2-git-send-email-pl@kamp.de>
Subject: Re: [Qemu-devel] [PATCHv2 01/11] iscsi: add logical block
 provisioning information to iscsilun
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Lieven <pl@kamp.de>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, ronniesahlberg@gmail.com

On Thu, Jun 27, 2013 at 03:11:25PM +0200, Peter Lieven wrote:
> @@ -1130,6 +1137,46 @@ static int iscsi_open(BlockDriverState *bs, QDict *options, int flags)
>          bs->sg = 1;
>      }
>  
> +    if (iscsilun->lbpme) {
> +        struct scsi_inquiry_logical_block_provisioning *inq_lbp;
> +        int full_size;
> +
> +        task = iscsi_inquiry_sync(iscsi, iscsilun->lun, 1,
> +                                  SCSI_INQUIRY_PAGECODE_LOGICAL_BLOCK_PROVISIONING,
> +                                  64);

Does this leak the previous task from line 1101?