From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51766)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1UtfCH-0002vz-Fa
	for qemu-devel@nongnu.org; Mon, 01 Jul 2013 10:35:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1UtfCE-0003zU-GB
	for qemu-devel@nongnu.org; Mon, 01 Jul 2013 10:35:17 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56408)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1UtfCE-0003zM-8E
	for qemu-devel@nongnu.org; Mon, 01 Jul 2013 10:35:14 -0400
Date: Mon, 1 Jul 2013 15:58:51 +0200
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20130701135851.GD20182@stefanha-thinkpad.redhat.com>
References: <1372338695-411-1-git-send-email-pl@kamp.de>
	<1372338695-411-8-git-send-email-pl@kamp.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1372338695-411-8-git-send-email-pl@kamp.de>
Subject: Re: [Qemu-devel] [PATCHv2 07/11] iscsi: let bdrv_create
 conditionally zero out the device
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Lieven <pl@kamp.de>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, ronniesahlberg@gmail.com

On Thu, Jun 27, 2013 at 03:11:31PM +0200, Peter Lieven wrote:
> @@ -1481,7 +1483,75 @@ static int iscsi_create(const char *filename, QEMUOptionParameter *options)
>      }
>  
>      ret = 0;
> +
> +    if (iscsilun->lbpu && iscsilun->lbprz) {

Moving this block of code into a function would be nice.