From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48139) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UtoG2-0000lY-6q for qemu-devel@nongnu.org; Mon, 01 Jul 2013 20:15:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UtoFs-0008Ky-5g for qemu-devel@nongnu.org; Mon, 01 Jul 2013 20:15:46 -0400 Date: Tue, 2 Jul 2013 10:06:35 +1000 From: David Gibson Message-ID: <20130702000635.GA4729@voom.fritz.box> References: <1372315560-5478-1-git-send-email-aik@ozlabs.ru> <1372315560-5478-3-git-send-email-aik@ozlabs.ru> <20130627114719.GG10614@voom.fritz.box> <51CC2D4F.9000401@ozlabs.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="MGYHOYXEY6WxJCY8" Content-Disposition: inline In-Reply-To: <51CC2D4F.9000401@ozlabs.ru> Subject: Re: [Qemu-devel] [PATCH 02/17] pseries: rework XICS List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: Anthony Liguori , qemu-devel@nongnu.org, Alexander Graf , qemu-ppc@nongnu.org, Paolo Bonzini , Paul Mackerras --MGYHOYXEY6WxJCY8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 27, 2013 at 10:17:19PM +1000, Alexey Kardashevskiy wrote: > On 06/27/2013 09:47 PM, David Gibson wrote: > > On Thu, Jun 27, 2013 at 04:45:45PM +1000, Alexey Kardashevskiy wrote: > >> Currently XICS interrupt controller is not a QEMU device. As we are go= ing > >> to support in-kernel emulated XICS which is a part of KVM, it make > >> sense not to extend the existing XICS and have multiple KVM stub funct= ions > >> but to create yet another device and share pieces between fully emulat= ed > >> XICS and in-kernel XICS. > >=20 > > Hmm. So, I think changing the xics to the qdev/qom framework is a > > generally good idea. But I'm not convinced its a good idea to have > > different devices for the kernel and non-kernel xics. >=20 > The idea came from Alex Graf, this is already done for openpic/openpic-kv= m. > The normal practice is to move ioctls to KVM to KVM code and provide empty > stubs for non-KVM case. There were too many so having a separate xics-kvm > is kind of help. >=20 >=20 > > Won't that > > prevent migrating from a system with a kernel xics to one without, or > > vice versa? >=20 > Mmm. Do we care much about that?... Enough to avoid making it impossible by design. > At the moment it is not supported that as VMStateDescription have differe= nt > .name for xics and xics-kvm but easy to fix. And we do not pass a device = to > vmstate_register so that must be it. Ok, if you can make the ids in the vmsd match, then that should be ok. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --MGYHOYXEY6WxJCY8 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) iEYEARECAAYFAlHSGYsACgkQaILKxv3ab8aUCgCdH4nn4pErCJEseHtzWVSLLzaM dF8AnjqlFC5ihww8186hjzSabYWcZsin =rJRI -----END PGP SIGNATURE----- --MGYHOYXEY6WxJCY8--